Opened on 04/07/2014 at 04:29:48 PM
Closed on 08/29/2019 at 05:43:52 PM
Last modified on 10/08/2019 at 05:42:58 PM
#271 closed change (rejected)
Do not attemp downloading filters if there is no internet connection
| Reported by: | trev | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | erikvold | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Currently the browser will try downloading filters regardless of whether there is an internet connection. It will fail and only try downloading again after a day.
What to change
We shouldn't try downloading if navigator.onLine is false, see https://developer.mozilla.org/en-US/docs/Web/API/NavigatorOnLine.onLine
Attachments (0)
Change History (5)
comment:1 Changed on 04/07/2014 at 05:58:06 PM by trev
comment:2 Changed on 04/30/2014 at 01:24:24 PM by philll
- Ready set
comment:3 Changed on 09/20/2018 at 06:26:14 AM by erikvold
- Cc erikvold added
- Platform set to Unknown / Cross platform
- Tester set to Unknown
comment:4 Changed on 08/16/2019 at 09:09:49 AM by noushadamir
spam
Last edited on 10/08/2019 at 05:42:58 PM
by kzar
comment:5 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Note: See
TracTickets for help on using
tickets.
Note that in Firefox we don't have access to a window so we would need to use nsIIOService.offline instead (https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIIOService#Attributes).