Opened on 07/01/2015 at 10:02:20 AM
Closed on 07/01/2015 at 06:21:30 PM
#2741 closed defect (fixed)
hg clone https://hg.adblockplus.org/libadblockplus not cloning all the required dependents
Reported by: | hemant | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Libadblockplus | Keywords: | |
Cc: | sergz | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
I am trying to clone libadblockplus repos on arm linux using
hg clone https://hg.adblockplus.org/libadblockplus
command from https://issues.adblockplus.org/ticket/1743
but its only checking out libadblockplus not its dependents.
It was working fine few months ago, is there something change in adblockplus repo?
I tried cloning missing repos from git repo but build is failing with following error :
make ARCH=arm7 gyp: name 'host_arch' is not defined while evaluating condition 'host_arch=="ia32" or host_arch=="x64" or clang==1' in libadblockplus.gyp while trying to load libadblockplus.gyp
can you please help?
Attachments (0)
Change History (6)
comment:1 Changed on 07/01/2015 at 12:54:53 PM by sergz
comment:2 Changed on 07/01/2015 at 12:58:28 PM by sergz
- Cc sergz added
- Component changed from Unknown to Libadblockplus
comment:3 Changed on 07/01/2015 at 02:55:35 PM by hemant
Thanks sergz. I got it working.
Few manual changes I have to do to get it build after running ./ensure_dependencies.py
- Add host_arch in libadblockplus/Makefile to allow build on arm host.
third_party/gyp/gyp --depth=. -f make -I common.gypi --generator-output=build -Dtarget_arch=$(ARCH) -Dhost_arch=$(ARCH) libadblockplus.gyp
- changes described in https://issues.adblockplus.org/ticket/1743
you can close this case.
comment:4 Changed on 07/01/2015 at 03:27:35 PM by sergz
BTW, we are going to add host_arch as well, there is a review for it https://codereview.adblockplus.org/6193234183192576/diff/5629499534213120/Makefile but the process will take some time.
Actually, I think that host_arch should be the architecture of the current host which, as I understand, is used to build tools to build v8.
comment:5 Changed on 07/01/2015 at 04:24:38 PM by hemant
ok. Thanks for info.
comment:6 Changed on 07/01/2015 at 06:21:30 PM by sergz
- Resolution set to fixed
- Status changed from new to closed
Yes, there are changes. Now to get dependencies one needs to call ./ensure_dependencies.py (a little bit more about it one can find in README.md). Please let us know if you are still experiencing any troubles with cloning.