Opened on 07/14/2015 at 04:09:36 PM

Closed on 07/14/2015 at 04:23:00 PM

#2784 closed change (fixed)

Update adblockplustests dependency to ae6c7a2cc723

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: sebastian Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29322308/

Description (last modified by sebastian)

Background

We need to update the adblockplustests dependency for adblockpluschrome in order to make the tests pass again since #2738 was pushed. (We forgot to do this at the time!)

Since the last update there have been three other commits:

https://hg.adblockplus.org/adblockplustests/rev/ecd65337246e
https://hg.adblockplus.org/adblockplustests/rev/469b5045912a
https://hg.adblockplus.org/adblockplustests/rev/e7fd9016aab1

Which all only make changes to chrome/content/tests/notification.js which is not included by the Chrome unit test runner and therefore should have no effect.

What to change

A dependency update is sufficient.

Hints for testers

This dependency has no effect on the builds.

Attachments (0)

Change History (3)

comment:1 Changed on 07/14/2015 at 04:12:44 PM by sebastian

  • Description modified (diff)
  • Ready set

comment:2 Changed on 07/14/2015 at 04:17:06 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 07/14/2015 at 04:23:00 PM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.