Opened on 07/20/2015 at 07:45:23 PM

Closed on 07/21/2015 at 01:53:44 PM

Last modified on 07/27/2015 at 10:09:40 AM

#2805 closed defect (fixed)

Regression: Error in Firefox first-run page: filterValidation module doesn't exist

Reported by:	greiner	Assignee:	greiner
Priority:	P1	Milestone:
Module:	User-Interface	Keywords:
Cc:		Blocked By:
Blocking:		Platform:	Firefox
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29322723/

Description

Environment

Firefox 42.0a1
Adblock Plus 2.6.9.3961 (with adblockplusui revision 20)

How to reproduce

Open first-run page
Open browser console

Observed behavior

The following error can be seen:

1437421089832 addons.xpi  WARN  Exception running bootstrap method startup on {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}: Error opening input stream (invalid filename?): jar:file:///home/thomas/.mozilla/firefox/njib3tdv.Default%20User/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/filterValidation.js

Expected behavior

No such error is shown.

Background

This is a regression from #2376 which occurs because the "filterValidation" module only exists in the context of adblockpluschrome. For now it should be sufficient to move the require() call to the respective message responses since they'll initially only be used in that context.

Later on we'll need an implementation or an abstraction of that module in the ext-API.

Change History (3)

comment:1 Changed on 07/21/2015 at 01:53:44 PM by greiner

Milestone set to Adblock-Plus-for-Firefox-next
Resolution set to fixed
Status changed from new to closed

https://hg.adblockplus.org/adblockplusui/rev/58b11aa4b12f

comment:2 Changed on 07/22/2015 at 10:28:59 AM by trev

Milestone Adblock-Plus-2.6.10-for-Firefox deleted

Removed milestone - this change wasn't imported into Adblock Plus for Firefox directly but as part of the dependency update in #2808.

comment:3 Changed on 07/27/2015 at 10:09:40 AM by greiner

Review URL(s) modified (diff)

Summary:

Description:

You may use WikiFormatting here.

Type:

Priority:

Milestone:

Module:

Keywords:

Cc:

Blocked By:

Blocking:

Platform:

Ready:

Confidential:

Tester:

Verified working:

Review URL(s):

Context Navigation

#2805 closed defect (fixed)

Regression: Error in Firefox first-run page: filterValidation module doesn't exist

Description

Environment

How to reproduce

Observed behavior

Expected behavior

Background

Attachments (0)

Change History (3)

comment:1 Changed on 07/21/2015 at 01:53:44 PM by greiner

comment:2 Changed on 07/22/2015 at 10:28:59 AM by trev

comment:3 Changed on 07/27/2015 at 10:09:40 AM by greiner

Add Comment

Modify Ticket

Changed by kzar

Download in other formats:

Summary:
Description:	You may use WikiFormatting here. === Environment === Firefox 42.0a1 Adblock Plus 2.6.9.3961 (with adblockplusui revision 20) === How to reproduce === 1. Open first-run page 2. Open browser console === Observed behavior === The following error can be seen: {{{ 1437421089832 addons.xpi WARN Exception running bootstrap method startup on {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}: Error opening input stream (invalid filename?): jar:file:///home/thomas/.mozilla/firefox/njib3tdv.Default%20User/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/filterValidation.js }}} === Expected behavior === No such error is shown. === Background === This is a regression from #2376 which occurs because the "filterValidation" module only exists in the context of adblockpluschrome. For now it should be sufficient to move the `require()` call to the respective message responses since they'll initially only be used in that context. Later on we'll need an implementation or an abstraction of that module in the ext-API.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/29322723/