Opened on 07/27/2015 at 04:34:39 PM
Closed on 09/02/2015 at 04:15:27 PM
#2822 closed change (fixed)
Add support for new subscription types to sitescripts
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2668, #2821, #2824 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
See #2821.
What to change
- Add "type" attribute to recommendations.xml template
- Don't output the "unknown type" warning for the types: ads, anti-adblock, other, malware, social, privacy
- Limit the "recommendation without language" warning to subscriptions with type "ads"
- Only append a subscription to "supplemented" if it's of the same type as its parent
Attachments (0)
Change History (6)
comment:1 Changed on 07/27/2015 at 04:40:49 PM by greiner
- Blocking 2824 added
comment:2 Changed on 07/27/2015 at 04:45:44 PM by greiner
- Blocking 2668 added
comment:3 Changed on 08/27/2015 at 02:09:30 PM by sebastian
- Priority changed from Unknown to P3
- Ready set
comment:4 Changed on 08/28/2015 at 05:26:51 PM by greiner
- Owner set to greiner
comment:5 Changed on 08/28/2015 at 05:44:28 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/02/2015 at 04:15:27 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/sitescripts/rev/3c673e29e967