Setting that enforces ABP to load completely at Firefox startup doesn't work

[tempuser1231]

By design ABP lets Firefox start loading pages before ABP is fully loaded. The result is a race condition where restored browsing sessions sometimes contain ads. This is a security issue due to malware served through ad networks, and a privacy issue due to tracking. #549 introduced the misleading setting extensions.adblockplus.please_kill_startup_performance to force ABP to completely load before Firefox loads pages. Unfortunately it doesn't work.

Environment

Any versions of Firefox and ABP released since extensions.adblockplus.please_kill_startup_performance was introduced.

How to reproduce

1. Configure Firefox to open the previous session on startup and enable extensions.adblockplus.please_kill_startup_performance in about:config
2. Open some windows and tabs with web sites that normally contain ads
3. Restart Firefox

Observed behaviour

Sometimes there are ads in parts of the restored session, as if extensions.adblockplus.please_kill_startup_performance was disabled. Unfortunately the issue can't be reproduced deterministically due to the nature of race conditions.

Expected behaviour

No ads in restored session, and by extension protection from malware and tracking.

[trev]

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.