Opened on 09/10/2015 at 02:52:35 PM
Closed on 08/29/2019 at 05:48:47 PM
#3055 closed change (rejected)
Fix inconsistencies with critical notifications
| Reported by: | greiner | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | Ross, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
There are a couple of user experience inconsistencies with critical notifications that were discovered while testing those. Critical notifications are not supposed to be closed or opted-out of. This should be reflected across the various display methods.
What to change
- Don't stop the icon animation (as implemented in #3096) if it's a critical notification.
- Don't show "close" button in the icon popup for critical notifications.
- Closing the desktop notification should not hide the notification in the icon popup for critical notifications.
Attachments (0)
Change History (6)
comment:2 Changed on 09/17/2015 at 08:35:10 PM by greiner
- Cc Ross added
comment:3 Changed on 10/20/2015 at 11:38:09 AM by kzar
Perhaps this issue should be turned into a meta issue containing a list of issues that need to be resolved? At the moment it is fairly vague, so I don't feel I can mark it as ready.
comment:4 Changed on 10/20/2015 at 01:24:03 PM by greiner
I didn't go into further technical detail because none of those changes require fundamental changes to the extension - overall they're pretty trivial (mostly about adding if-statements where appropriate).
comment:5 Changed on 01/20/2016 at 12:45:43 PM by sebastian
- Cc sebastian added
- Priority changed from Unknown to P3
- Ready set
If you don't want to split this up into multiple issues fine with me. But please consider splitting it up in multiple reviews/commits though. Otherwise these changes sound reasonable.
comment:6 Changed on 08/29/2019 at 05:48:47 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
There's now a separate ticket for stopping the icon animation (see #3096) so I modified the description accordingly.