Opened on 09/14/2015 at 02:12:33 PM

Closed on 09/15/2016 at 03:11:00 PM

#3069 closed change (rejected)

Change settings label from "Ad blocking" to "Adblock Plus"

Reported by: sven Assignee: diegocarloslima
Priority: Unknown Milestone:
Module: Adblock-Browser-for-Android Keywords:
Cc: rjeschke, athornburgh, lisabielik, fhd Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29341460/

Description

Background

If you click the settings icon you will see the first layout of the settings which includes the label "Ad blocking". If you click that one there is another label which is called "Ad blocking", which is kind of confusing. In iOS we use "Adblock Plus" in the first layer.

What to change

Change settings label in first settings layer from "Ad blocking" to "Adblock Plus"

Attachments (0)

Change History (5)

comment:1 Changed on 05/13/2016 at 03:43:29 PM by diegocarloslima

  • Owner set to diegocarloslima

comment:2 Changed on 05/17/2016 at 10:03:33 AM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/15/2016 at 09:18:07 AM by fhd

  • Cc athornburgh lisabielik fhd added

Lisa, Aaron, can you let me know whether this change is actually (still) desired?

comment:4 Changed on 09/15/2016 at 01:42:33 PM by lisabielik

@fhd

I don't think it's necessary.

comment:5 Changed on 09/15/2016 at 03:11:00 PM by fhd

  • Resolution set to rejected
  • Status changed from reviewing to closed

Alright, let's not do it then.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
 
Note: See TracTickets for help on using tickets.