Opened on 09/22/2015 at 12:17:29 PM

Closed on 10/19/2015 at 01:55:53 PM

Last modified on 12/14/2015 at 11:00:01 AM

#3108 closed defect (fixed)

Firefox Nightly elements no longer works

Reported by: fanboy Assignee: trev
Priority: P1 Milestone: Adblock-Plus-2.7-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: e10s 2015q4
Cc: arthur, mapx Blocked By: #3227, #3290
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



Launch Firefox Nightly (latest)

How to reproduce

  1. With Adblock Plus-Dev installed open a website (such as )
  1. NS_ERROR_DOM_BAD_URI: Access to restricted URI denied1 RemoteAddonsChild.jsm:283:0

Security Error: Content at may not load data from about:abp-elemhidehit?154911587633.

  1. Elements don't hide because of this error message

Attachments (0)

Change History (22)

comment:1 Changed on 09/22/2015 at 06:40:16 PM by trev

  • Component changed from Unknown to Adblock-Plus-for-Firefox
  • Priority changed from Unknown to P1
  • Ready set

This is a regression from bug 1204703 it seems. For some reason I cannot see this error message but I do see the impact of it.

comment:2 follow-up: Changed on 09/25/2015 at 02:30:11 PM by fanboy

Do we need a fix in Firefox or is there a fix coming for ABP?

comment:3 Changed on 10/08/2015 at 12:48:10 AM by Evengard

Actually it seems that it is trying to hiding elements, but the exception rules doesn't work. here is a report of one of such behaviour. Even more it doesn't show that it hid elements in the hiding log. And seems to actually lag a lot because of that.

I would considering this as very important, but not sure if this is ABP or Firefox bug.

comment:4 Changed on 10/11/2015 at 07:50:42 AM by Evengard

Reported on Firefox issue tracker here: let's see their answer.

comment:5 in reply to: ↑ 2 Changed on 10/15/2015 at 02:09:57 PM by trev

Replying to fanboy:

Do we need a fix in Firefox or is there a fix coming for ABP?

Unfortunately, that depends on whether ABP is making wrong assumptions or the new security checks have a bug - and that's not exactly easy to say.

comment:6 Changed on 10/15/2015 at 03:12:25 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

After looking some more into this, the issue can be fixed on our end.

comment:7 Changed on 10/15/2015 at 03:37:09 PM by trev

My bad, this only fixes it as long as E10S isn't enabled. While this change is certainly necessary, in E10S mode we still have the same issue - it seems that the about: protocol handler will do security checks before even consulting us.

comment:8 Changed on 10/15/2015 at 06:06:29 PM by trev

  • Status changed from reviewing to reopened

First part has been pushed:

Fixing the rest of it requires getting our about: protocol handler into the content process instead of the compatibility shim. Working on that.

comment:9 Changed on 10/15/2015 at 06:06:40 PM by trev

  • Owner set to trev

comment:10 Changed on 10/16/2015 at 12:22:12 PM by trev

  • Keywords e10s added
  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

Second change fixes the remaining parts now. Side-effect is that element hiding hits will no longer appear in the blockable items window (still visible via Diagnostics extension). This issue requires #3208 to be fixed first.

comment:11 Changed on 10/16/2015 at 01:15:15 PM by arthur

  • Cc arthur added

comment:12 Changed on 10/16/2015 at 08:04:17 PM by trev

Pushed the second change:

Leaving the issue open in order to clean up a bit.

comment:13 Changed on 10/16/2015 at 08:08:54 PM by trev

  • Review URL(s) modified (diff)

comment:14 Changed on 10/16/2015 at 09:05:09 PM by trev

  • Review URL(s) modified (diff)

comment:15 Changed on 10/19/2015 at 12:08:03 PM by Evengard

The version before the cleanup (the one within the ABP dev build) seems to be working on latest Firefox Alpha (2015-10-18)

comment:16 Changed on 10/19/2015 at 01:55:53 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Last edited on 10/19/2015 at 01:59:48 PM by trev

comment:17 Changed on 10/20/2015 at 06:00:25 AM by Evengard

It seems to also work, but I've got the problem of twitch video ads not being blocked. I'm not sure this is related to theese changes, but even yesterday all was alright. But well it could be that they updated something on twitch.

comment:18 Changed on 10/22/2015 at 06:13:09 PM by trev

  • Blocked By 3227 added

comment:19 Changed on 10/26/2015 at 03:13:54 PM by mapx

  • Cc mapx added

comment:20 Changed on 11/09/2015 at 03:00:24 PM by mario

  • Keywords 2015q4 added

comment:21 Changed on 11/09/2015 at 03:36:39 PM by trev

  • Blocked By 3290 added

comment:22 Changed on 12/14/2015 at 10:29:42 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Element hiding works again in Nightly.

Firefox 45 Nightly (2015-12-13) / Ubuntu 14.04

Last edited on 12/14/2015 at 11:00:01 AM by Ross

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.