Opened on 09/25/2015 at 08:49:26 AM
Closed on 10/26/2015 at 05:02:19 PM
Last modified on 11/04/2015 at 10:31:28 AM
#3123 closed defect (fixed)
Adblock Browser for iOS opens two tabs when tapping external links on facebook
| Reported by: | philll | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Browser-for-iOS-1.2.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | salsita |
| Cc: | pavelz, mario | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by philll)
Environment
iPhone 6 Plus
iOS 9.1 (13B5110e)
Adblock Browser v1.1.0 (core 1.3.0)
Original report: https://adblockplus.org/forum/viewtopic.php?f=25&t=40613&p=138944#p138920
How to reproduce
- Log in to Facebook.com
- Go to https://m.facebook.com/adblockplus
- In the about section, tap the URL https://adblockplus.org
Observed behaviour
Two new tabs open with the tapped URL.
Expected behaviour
One new tab should open with the tapped URL.
Attachments (0)
Change History (12)
comment:2 Changed on 09/25/2015 at 08:54:46 AM by philll
- Ready set
comment:3 Changed on 09/25/2015 at 09:07:25 AM by vojtab
comment:4 Changed on 09/30/2015 at 01:37:49 PM by pavelz
Can't reproduce. Only one new tab opens for me. Are you logged in FB or anonymous?
comment:5 Changed on 09/30/2015 at 07:06:44 PM by philll
- Cc pavelz added
As described in the How to reproduce section, I was logged in. The behaviour doesn't occur with the public version of the URL.
comment:6 Changed on 10/06/2015 at 08:50:33 AM by mario
- Cc mario added
- Priority changed from Unknown to P3
Temporarly set to P3 unless we discover, that it's a broader problem and other sites are affected as well.
comment:7 Changed on 10/12/2015 at 11:14:20 AM by mario
- Keywords salsita added
comment:8 Changed on 10/26/2015 at 09:47:24 AM by pavelz
- Priority changed from P3 to P1
comment:9 Changed on 10/26/2015 at 05:02:19 PM by pavelz
- Resolution set to fixed
- Status changed from new to closed
comment:10 Changed on 11/03/2015 at 10:06:48 AM by philll
@pavel: Could you please provide some background on this, specifically, why it's a P1 in the end and what areas are affected to allow testers to best do their job.
comment:11 Changed on 11/03/2015 at 10:33:36 AM by pavelz
The issue applies to any site which hooks its own generic click handler on documentElement. Facebook specifically wants to run its own window.open on any <a target="_blank"> which is what Kitt core already does for sites not as opinionated as Facebook. Regarding testability, there is no other deterministically known site doing that, an onlick on a specific DOM element is more common practice which does not intersect with this issue. But the click hooking it is a completely legal and expectable activity which was generally mishandled by Kitt core. So it was assigned P1 and fixed preemptively.
comment:12 Changed on 11/04/2015 at 10:31:28 AM by mario
- Milestone set to Adblock-Browser-for-iOS-next
https://www.pivotaltracker.com/story/show/104162956