Opened on 09/29/2015 at 12:34:55 PM

Closed on 03/15/2016 at 02:40:10 PM

#3132 closed change (fixed)

Remove unused subscriptionList.html from sitescripts

Reported by: greiner Assignee:
Priority: P4 Milestone:
Module: Sitescripts Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://github.com/adblockplus/sitescripts/pull/1

Description

Background

In #1170 we migrated adblockplus.org from Anwiki to our own CMS which included moving the subscription list page from sitescripts to web.adblockplus.org. Therefore sitescripts' subscriptionList.html is no longer used and should therefore be removed to avoid confusion.

What to change

  • Remove sitescripts/subscriptions/template/subscriptionList.html.
  • Don't mention the subscriptionList template in processTemplate.py anymore.

Attachments (0)

Change History (3)

comment:1 Changed on 10/20/2015 at 09:37:27 AM by kzar

  • Keywords goodfirstbug added
  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed on 03/15/2016 at 02:37:24 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/sitescripts/rev/c191dcfed86c

comment:3 Changed on 03/15/2016 at 02:40:10 PM by sebastian

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

Thanks, Andrey!

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.