Opened on 04/13/2014 at 06:23:26 AM
Closed on 07/31/2019 at 05:15:13 PM
#315 closed change (duplicate)
Add a way to disable custom filters in browsers besides Firefox
| Reported by: | Gingerbread Man | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | mapx, sebastian, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
Filter issues are the most common cause of Adblock Plus failing to perform correctly. In Firefox, disabling custom filters is a cinch. In other browsers, this isn't possible: all filters have to be removed. This makes troubleshooting a convoluted process that involves cutting all filters to the clipboard and saving them in a text editor. It's not a great user experience.
There should be an "Enabled" checkbox at the top of the Add Your Own Filters tab, so that people can keep their filters and quickly check if they're causing problems.
What to change
See ui#20.
Attachments (1)
Change History (12)
Changed on 04/13/2014 at 06:24:07 AM by Gingerbread Man
comment:1 Changed on 04/13/2014 at 07:25:11 AM by mapx
- Cc smultron45@gmail.com added
comment:2 Changed on 04/14/2014 at 01:20:19 PM by trev
- Cc trev added
comment:3 Changed on 04/14/2014 at 02:24:58 PM by philll
- Priority changed from Unknown to P4
- Ready set
comment:4 Changed on 07/09/2014 at 12:38:11 PM by philll
- Platform set to Firefox
comment:5 Changed on 06/16/2016 at 06:58:31 AM by mapx
- Cc mapx sebastian greiner kzar added; smultron45@gmail.com removed
- Platform changed from Firefox to Unknown / Cross platform
- Tester set to Unknown
comment:6 Changed on 06/20/2016 at 11:55:29 AM by kzar
- Cc kzar removed
comment:7 Changed on 12/21/2017 at 11:29:03 AM by fhd
- Cc trev removed
comment:8 Changed on 01/15/2018 at 02:21:59 PM by greiner
- Priority changed from P4 to P3
- Ready unset
I've created a spec ticket at https://gitlab.com/eyeo/spec/issues/130 because I think this'd be a nice, quick improvement we could make until we are able to reintroduce filter groups.
comment:9 Changed on 02/06/2018 at 11:14:49 AM by agiammarchi
- Owner set to agiammarchi
comment:10 Changed on 08/06/2018 at 05:34:38 PM by greiner
- Description modified (diff)
- Ready set
Added reference to GitLab issue which is currently being worked on.
comment:11 Changed on 07/31/2019 at 05:15:13 PM by greiner
- Description modified (diff)
- Resolution set to duplicate
- Status changed from new to closed
We ended up having to remove this feature from #7160 which replaces the textarea with the new custom filter table. The reason for it was that custom filters are spread out across multiple custom filter lists rather than a single one which makes it more difficult to implement. However, we could introduce it together with filter groups when we get around to implementing those in ui#28.
Anyway, I'm closing this ticket in favor of ui#20 which I've reopened so that we can keep track of this request.
customfilters_comparison.png