Opened on 10/27/2015 at 12:31:46 PM
Closed on 12/16/2015 at 12:45:35 PM
Last modified on 12/15/2016 at 06:19:39 AM
#3237 closed defect (fixed)
Whitelisted AFS ad is not shown on netzwelt.de
| Reported by: | sergz | Assignee: | oleksandr |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr, sergz, eric@…, greiner | Blocked By: | |
| Blocking: | #3368 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Rraceanu | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by oleksandr)
Environment
IE 11, ABP 1.5, EasyList Germany+EasyList, Allow some non-intrusive advertising is enabled.
How to reproduce
- Go to http://netzwelt.de
- search for something, iphone for example
Observed behaviour
AFS is not shown
Expected behaviour
AFS should be shown.
Additional info
Request http://cse.google.com/cse?q=iphone&r=m&cx=0... is detected as IMAGE because Accept header is text/html, application/xhtml+xml, image/jxr, */*, so the request is blocked, however fixing only of this request is not enough.
| google.com/cse?$subdocument,document,domain=netzwelt.de should be applied, but due to incorrect ShouldBlock call, domain is not resolved. |
Attachments (0)
Change History (11)
comment:1 Changed on 10/27/2015 at 12:34:22 PM by sergz
comment:2 Changed on 10/28/2015 at 09:58:21 AM by oleksandr
- Platform changed from Unknown / Cross platform to Internet Explorer
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 11/27/2015 at 10:54:07 AM by oleksandr
- Cc sergz eric@… added
- Priority changed from P2 to P1
comment:4 Changed on 12/01/2015 at 02:24:10 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 12/01/2015 at 02:26:21 AM by oleksandr
- Description modified (diff)
- Owner set to oleksandr
comment:6 Changed on 12/02/2015 at 08:52:53 PM by oleksandr
- Blocking 3368 added
comment:7 Changed on 12/03/2015 at 11:10:29 AM by greiner
- Cc greiner added
comment:8 Changed on 12/16/2015 at 12:45:35 PM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
This has been pushed: https://hg.adblockplus.org/adblockplusie/rev/ffd5291ca115. This and #3368 both seem to be fixed now. A fix will be included in a nearest devbuild, which we can build once #3412 is fixed.
comment:9 Changed on 12/16/2015 at 12:47:53 PM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
comment:10 Changed on 11/08/2016 at 12:58:04 AM by rraceanu
- Tester changed from Unknown to Rraceanu
comment:11 Changed on 12/15/2016 at 04:59:02 AM by rraceanu
- Verified working set
Change successfully implemented, Whitelisted ads are shown with Easylist Germany+ Easylist and AA enabled on netzwelt.de whilst doing a search query, verified on IE 10 Windows 8 and IE 11 Windows 10, ABP version 1.5.856.
Merely for reference, it's not a duplicate of #1210