Pop-up blocker unit tests broken in E10S mode

[trev]

Environment

Firefox 45.0a1

How to reproduce

1. Make sure "Enable multi-process Nightly" is enabled in Firefox preferences.
2. Go into Adblock Plus unit tests preferences, select popupBlocker and click Run.

Observed behaviour

The test opens pop-up windows but doesn't close them. Closing them manually makes the test complete, albeit with failures.

Expected behaviour

The test should run through without issues, as it does when E10S is disabled.

[erikvold]

​https://codereview.adblockplus.org/29331996

[erikvold]

Just for the record, these where the errors that I saw in the console before my patch is applied:

unsafe CPOW usage remote-browser.xml:164:0
unsafe CPOW usage popupBlocker.js:119:4
TypeError: browser.contentWindow.addEventListener is not a function popupBlocker.js:93:1
GET
​http://127.0.0.1:1234/redirect [HTTP/1.1 302 Moved Temporarily 4ms]
GET
​http://127.0.0.1:1234/test [HTTP/1.1 200 OK 7ms]
unsafe CPOW usage remote-browser.xml:164:0
unsafe CPOW usage popupBlocker.js:119:4
TypeError: browser.contentWindow.addEventListener is not a function

[erikvold]

​https://hg.adblockplus.org/adblockplustests/rev/e3e79e4e1a39

[trev]

It seems that there are two issues with the solution here, too bad I didn't test it earlier:

1. The tests won't work with the pop-up blocker enabled (previously we were simulating proper user clicks that the built-in pop-up blocker wouldn't catch).
2. It seems that tabs.on("ready") functionality in the Add-on SDK relies on E10S compatibility shims. Since Adblock Plus no longer uses them the test won't work in E10S mode.

[trev]

Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.