Opened on 10/29/2015 at 07:54:09 PM
Closed on 11/02/2016 at 01:51:33 PM
Last modified on 06/20/2017 at 08:21:57 AM
#3247 closed defect (fixed)
Closing the browser shortly after initial launch(s) causes no filters lists to be selected
| Reported by: | Ross | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | no | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Adblock Browser 1.0.0.201510
Xperia Z / Android 5.0.2
How to reproduce
- Open the Settings > App menu on the device.
- Force stop and clear data for Adblock Browser.
- Launch Adblock Browser.
- When the FRP appears, close the Adblock Browser via device task menu (swipe away).
- Launch Adblock Browser again.
- When the homescreen appears, count to 2.
- Close Adblock Browser via device task menu (swipe away) again.
- Launch Adblock Browser again.
- Select [Menu] > [Settings] > [Ad blocking] > [Ad blocking].
- Observe the filter list has been fetched already.
- Observe no filter list has been "default selected"
Observed behaviour
After performing the steps above the user will have no filter list default selected. Step 6 is important because if the browser is closed again too early or too late they will have a filter list default selected as expected.
It doesn't matter if they skip or pass through the FRP in Step 4.
Expected behaviour
The user should always have a filter list default selected however they close/mess around with the browser's initial launches.
Attachments (0)
Change History (7)
comment:1 Changed on 10/29/2015 at 07:57:31 PM by Ross
comment:2 Changed on 11/10/2015 at 02:50:05 PM by fhd
- Milestone Adblock-Browser-for-Android-1.1.0 deleted
comment:3 Changed on 08/11/2016 at 10:04:29 AM by diegocarloslima
- Owner set to diegocarloslima
comment:4 Changed on 08/24/2016 at 10:37:58 AM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 11/02/2016 at 01:49:19 PM by abpbot
A commit referencing this issue has landed:
Issue 3247 - Closing the browser shortly after initial launch(s) causes no filters lists to be selected
comment:6 Changed on 11/02/2016 at 01:51:33 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 06/20/2017 at 08:21:57 AM by scheer
- Tester changed from Ross to Scheer
- Verified working set
- The user now always has a filter list by default selected even with the browser start up closing as described above.
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
ABB adblockbrowser-1.1.1.20170612182010-arm
Xperia Z
Android 5.0.2.
This might be the cause of some users having no filter lists active after their initial install. The 2 second wait at Step 6 seems to matter and I can constantly reproduce it.
Noticed this when an automated test kept causing the conditions.