Opened on 11/02/2015 at 08:09:03 PM
Closed on 11/26/2015 at 01:49:10 PM
#3258 closed change (fixed)
Fix Size column and item flashing
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.7-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | e10s |
| Cc: | Blocked By: | ||
| Blocking: | #3222 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29329779/ |
||
Description
Background
With #3222 fixed the blockable items list can no longer access the DOM elements corresponding with the list entries. This breaks the Size column and item flashing.
What to change
Make the child-side RequestNotifier object store the elements it reports in a map, so that the parent-side has an identifier it can use to refer to them later. Add RequestNotifier.flashItem() method that will message the client side in order to flash an element. Also add a RequestNotifier.getSize() method to retrieve the size for an element. The latter has to be asynchronous, so the blockable items list will show the value as empty at first and invalidate it later. The size should be cached after that so that no more messaging is required.
Attachments (0)
Change History (4)
comment:2 Changed on 11/05/2015 at 09:29:07 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/06/2015 at 07:03:21 PM by trev
- Owner set to trev
comment:4 Changed on 11/26/2015 at 01:49:10 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Fixed on e10s branch:
https://hg.adblockplus.org/adblockplus/rev/11278af73c33
https://hg.adblockplus.org/adblockplus/rev/20b2ffc64fb2