Opened on 11/06/2015 at 01:15:02 PM
Closed on 02/25/2016 at 07:05:38 AM
#3281 closed change (fixed)
Add "Delete Bookmark" option to "Edit Bookmark" dialog
| Reported by: | sven | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-iOS-1.3.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | salsita |
| Cc: | mario, scheer | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Background
We're adding two new features/possibilities to add and edit bookmarks/dashboard items. Therefore it's not only possible to reach the edit mode of the bookmarks via the bookmarks section, but also via the dashboard, where it is not possible to delete bookmarks, if you want that.
What to change
Add a "Delete Bookmark" option in the "Edit Bookmark" dialog. This option should be styled in the default iOS red color and should have a 70px space between the last edit item (in that case "Show in Dashboard")
After clicking the option a default modal dialog should appear with the following wording:
Headline: "Delete Bookmark"
Text: "Are you sure you want to delete this bookmark?"
Button 1 (left): "Delete" (in default red)
Button 2 (right): "Cancel" (in default blue)
Tapping "Delete" will close the modal dialog, close the "Edit Bookmark" dialog and remove the bookmark.
Tapping "Cancel" will close the modal dialog.
Attachments (1)
Change History (14)
Changed on 11/06/2015 at 01:16:51 PM by sven
comment:1 Changed on 11/06/2015 at 01:21:34 PM by sven
- Cc salsita mario added
- Component changed from Unknown to Adblock-Browser-for-iOS
- Description modified (diff)
- Platform changed from Unknown / Cross platform to Adblock Browser for iOS
- Priority changed from Unknown to P3
comment:2 Changed on 11/06/2015 at 01:24:36 PM by sven
- Priority changed from P3 to P2
comment:3 Changed on 11/30/2015 at 09:55:57 AM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed on 11/30/2015 at 10:27:26 AM by mario
- Milestone set to Adblock-Browser-for-iOS-next
comment:5 Changed on 02/17/2016 at 02:20:24 PM by scheer
- Cc scheer added
- Resolution fixed deleted
- Status changed from closed to reopened
- The 'Delete Bookmark' is present in the 'Edit Bookmark' dialog.
- Upon selecting the 'Delete Bookmark' option the user is presented with a modal dialog that states:Headline: "Delete Bookmark" Text: "Are you sure you want to delete this bookmark?" Button 1 (left): "Delete" (in default red) Button 2 (right): "Cancel" (in default blue).
- After selecting the Delete option, the bookmark is not deleted.
Please note - that there is an issue linked to this feature and can be found here: https://issues.adblockplus.org/ticket/3666#ticket
ABB 1.3.0-qa (814)
iPhone 5C 16GB - iOS 9.2.1
iPhone 6 Plus 16GB - iOS 9.1
comment:6 Changed on 02/17/2016 at 04:32:09 PM by philll
Well, the ticket was implemented as required by the what to change section - it simply doesn't state that tapping those buttons should do anything. Note however that implementation should never have started initially since the ticket is not set to ready (it obviously also just isn't).
comment:9 Changed on 02/19/2016 at 09:39:03 AM by mario
- Cc salsita removed
- Keywords salsita added
comment:10 Changed on 02/23/2016 at 03:21:20 PM by mario
- Keywords salsita removed
comment:11 Changed on 02/24/2016 at 03:41:45 PM by mario
- Keywords salsita added
comment:12 Changed on 02/24/2016 at 03:50:09 PM by jand
@scheer: Can you please retest this feature on real device?
comment:13 Changed on 02/25/2016 at 07:05:38 AM by scheer
- Resolution set to fixed
- Status changed from reopened to closed
- Tester changed from Unknown to Scheer
- Verified working set
- After selecting the Delete option, the bookmark is deleted.
ABB 1.3.0-qa (836)
iPhone 6 Plus - iOS 9.2.1
https://www.pivotaltracker.com/story/show/109024040