Opened on 04/15/2014 at 01:31:14 PM

Closed on 08/25/2014 at 10:40:20 AM

Last modified on 08/25/2014 at 10:58:46 AM

#331 closed change (fixed)

Remove localStorage to FileSystem migration code

Reported by: trev Assignee: saroyanm
Priority: P3 Milestone: Adblock-Plus-1.8.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Opera
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by saroyanm)


We were originally using localStorage to store our data in Opera and switched over to FileSystem API later. This was several releases ago but there is still migration code running every time the extension initializes and looking for patterns.ini in localStorage.

What to change

Remove the migration code and the complexity that it introduces.

Hint for testers

This issue can affect only users who had stored data in localStorage with key patterns.ini, while the migration code was introduced long time ago (9 month) and were migrating the data with each new version of ABP, It can only affect users if they didn't get update for more than half a year.

Attachments (0)

Change History (8)

comment:1 Changed on 08/13/2014 at 01:52:09 PM by saroyanm

  • Owner set to saroyanm
  • Platform set to Unknown

comment:2 Changed on 08/13/2014 at 01:52:44 PM by saroyanm

  • Platform changed from Unknown to Opera

comment:3 Changed on 08/14/2014 at 11:35:14 AM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 08/25/2014 at 10:40:20 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 08/25/2014 at 10:42:00 AM by saroyanm

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next

comment:6 Changed on 08/25/2014 at 10:54:16 AM by saroyanm

  • Description modified (diff)

comment:7 Changed on 08/25/2014 at 10:57:43 AM by saroyanm

  • Description modified (diff)

comment:8 Changed on 08/25/2014 at 10:58:46 AM by saroyanm

  • Description modified (diff)

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Note: See TracTickets for help on using tickets.