Opened on 11/12/2015 at 01:28:53 PM

Closed on 04/05/2016 at 06:42:09 AM

#3310 closed defect (fixed)

Settings items stay focused when swiping to navigate

Reported by:	mario	Assignee:
Priority:	P3	Milestone:	Adblock-Plus-for-iOS-next
Module:	Adblock-Plus-for-iOS/macOS	Keywords:	salsita
Cc:		Blocked By:
Blocking:		Platform:	iOS
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://github.com/adblockplus/adblockplussafariios/pull/28

Description

Environment

iPhone 6
iOS 9.1
ABB v1.0.1
ABB v1.0.1 DevBuild (as of 2015-11-12)

How to reproduce

Open Adblock Plus
Open the Adblock Plus settings
Tap on "Acceptable Ads" (The Acceptable Ads settings will open)
Navigate back using a swipe from the left corner of the screen to the right

Observed behaviour

The previously tapped "Acceptable Ads" button stays focused (dark grey background color)

Expected behaviour

The previously tapped "Acceptable Ads" button should lose focus and its state should already be back to normal (light grey background color)
You can see the correct behavior by not swiping but by using the back button:

Open Adblock Plus
Open the Adblock Plus settings
Tap on "Acceptable Ads" (The Acceptable Ads settings will open)
Navigate back using a the "< Adblock Plus" back button in the upper left corner

Change History (4)

comment:1 Changed on 12/14/2015 at 01:56:43 PM by mario

Priority changed from Unknown to P3
Ready set

comment:2 Changed on 03/07/2016 at 05:07:53 PM by jand

Review URL(s) modified (diff)
Status changed from new to reviewing

comment:3 Changed on 04/05/2016 at 06:40:44 AM by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplussafariios/rev/83397c3722c9

comment:4 Changed on 04/05/2016 at 06:42:09 AM by fhd

Milestone set to Adblock-Plus-for-iOS-next
Resolution set to fixed
Status changed from reviewing to closed

Summary:

Description:

You may use WikiFormatting here.

Type:

Priority:

Milestone:

Module:

Keywords:

Cc:

Blocked By:

Blocking:

Platform:

Ready:

Confidential:

Tester:

Verified working:

Review URL(s):

Context Navigation

#3310 closed defect (fixed)

Settings items stay focused when swiping to navigate

Description

Environment

How to reproduce

Observed behaviour

Expected behaviour

Attachments (0)

Change History (4)

comment:1 Changed on 12/14/2015 at 01:56:43 PM by mario

comment:2 Changed on 03/07/2016 at 05:07:53 PM by jand

comment:3 Changed on 04/05/2016 at 06:40:44 AM by abpbot

comment:4 Changed on 04/05/2016 at 06:42:09 AM by fhd

Add Comment

Modify Ticket

Changed by kzar

Download in other formats:

Summary:
Description:	You may use WikiFormatting here. === Environment === iPhone 6 iOS 9.1 ABB v1.0.1 ABB v1.0.1 DevBuild (as of 2015-11-12) === How to reproduce === 1. Open Adblock Plus 2. Open the Adblock Plus settings 3. Tap on "Acceptable Ads" (The Acceptable Ads settings will open) 4. Navigate back using a swipe from the left corner of the screen to the right === Observed behaviour === The previously tapped "Acceptable Ads" button stays focused (dark grey background color) === Expected behaviour === The previously tapped "Acceptable Ads" button should lose focus and its state should already be back to normal (light grey background color) You can see the correct behavior by not swiping but by using the back button: 1. Open Adblock Plus 2. Open the Adblock Plus settings 3. Tap on "Acceptable Ads" (The Acceptable Ads settings will open) 4. Navigate back using a the "< Adblock Plus" back button in the upper left corner
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://github.com/adblockplus/adblockplussafariios/pull/28