Opened on 11/17/2015 at 03:00:23 PM
Closed on 11/18/2015 at 10:01:21 AM
Last modified on 11/18/2015 at 11:11:07 AM
#3332 closed change (fixed)
Update adblockplus repository dependency to revision 4f4db95e3e35
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-1.9.4-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | trev, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
We should update the adblockplus dependency before releasing Adblock Plus for Chrome/Opera/Safari 1.9.4. The following relevant changes will be included:
Issue 3254 - Anti-adblock warning should not show when Adblock Plus is disabled
Issue 3254 - Fix exception when navigating to about:addons and similar pages
Issue 3208 - Don't use numerical content types outside nsIContentPolicy.shouldLoad
Issue 3208 - Consider private browsing in contentPolicy module rather than filterStorage
Issue 3208 - Move isBlockableScheme call from shouldLoad() into processNode()
Issue 3222 - Expose filter type as a string property
What to change
Updating the dependency should be sufficient.
What to test
- That notifications still work
- That element hiding still works
- That filter storage still works
Attachments (0)
Change History (8)
comment:2 Changed on 11/17/2015 at 04:43:47 PM by kzar
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/17/2015 at 06:54:09 PM by kzar
- Summary changed from Update adblockplus repository dependency to revision 38734339b8a8 to Update adblockplus repository dependency to revision 4f4db95e3e35
comment:4 Changed on 11/17/2015 at 09:56:23 PM by sebastian
comment:5 Changed on 11/17/2015 at 09:56:46 PM by sebastian
- Cc sebastian added
comment:6 Changed on 11/18/2015 at 10:01:21 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
It seems that most of the changes listed here don't even change any code in the resulting Adblock Plus for Chrome, Opera and/or Safari builds. Please only list changes that have any effect on the generated builds. Same for the other dependency updates you recently filed.