Opened on 11/23/2015 at 02:34:28 PM
Closed on 11/26/2015 at 12:52:49 PM
Last modified on 11/21/2016 at 10:46:46 AM
#3343 closed change (fixed)
Do not unescape URLs
| Reported by: | oleksandr | Assignee: | eric@… |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.6 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr, sergz, eric@ | Blocked By: | |
| Blocking: | #3300 | Platform: | Internet Explorer |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by oleksandr)
Background
We are currently unescaping the URLs before the ShouldBlock call in the traverser. This causes issues like: #3300. Bases on discussion in #3311 we shouldn't unescape before the Matches call at all. Seeing that we don't generally need to unescape URLs anywhere at all, we can just remove the UrlUnescape everywhere.
What to change
Remove UrlUnescape definition and calls.
Attachments (0)
Change History (3)
comment:1 Changed on 11/25/2015 at 02:19:15 AM by oleksandr
comment:2 Changed on 11/26/2015 at 12:52:49 PM by eric@adblockplus.org
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 11/21/2016 at 10:46:46 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-Next
Note: See
TracTickets for help on using
tickets.
