Opened on 12/02/2015 at 11:30:28 AM

Closed on 12/15/2015 at 01:15:41 PM

#3366 closed change (fixed)

Add tab for press releases to eyeo.com/press

Reported by: greiner Assignee: saroyanm
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: saroyanm, ben Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29332433/

Description (last modified by saroyanm)

Background

We'd like to have a press releases page on the Eyeo press page to be able to link to our press releases. This ticket was originally part of #2106.

What to change

On eyeo.com/press:

  • Remove the right column that contains "Recent coverage" (make sure that the center column occupies the freed-up space)
  • Add a new tab "Press releases" right next to the tab "Images"
    • Add two sections "English" and "German" - one after the other - and deep-link to them from the top of the tab content
    • Add the attached (English and German) PDFs to the "Press releases" tab based on the attached design
      • Press releases should be sorted by date in descending order
      • The date can be taken directly from the PDF file names
      • The shown title can be taken directly from within the PDF documents

Attachments (6)

press page update 3.jpg (961.1 KB) - added by greiner on 12/02/2015 at 11:31:26 AM.
press-en.zip (1.1 MB) - added by saroyanm on 12/02/2015 at 06:54:25 PM.
Press releases (English)
Screenshot from 2015-12-03 11:49:37.png (147.3 KB) - added by saroyanm on 12/03/2015 at 10:50:25 AM.
long titles
iphone.png (119.4 KB) - added by saroyanm on 12/03/2015 at 11:42:41 AM.
press-en.2.zip (1.1 MB) - added by saroyanm on 12/07/2015 at 03:52:36 PM.
Press releases (English)
press-de.zip (1.8 MB) - added by saroyanm on 12/07/2015 at 03:54:09 PM.
Press releases (German)

Download all attachments as: .zip

Change History (25)

Changed on 12/02/2015 at 11:31:26 AM by greiner

comment:1 Changed on 12/02/2015 at 11:34:32 AM by greiner

  • Description modified (diff)

comment:2 Changed on 12/02/2015 at 11:38:56 AM by greiner

  • Description modified (diff)

Note that I also included the "Remove right sidebar" change in this ticket to avoid the line break in the tab group.

Changed on 12/02/2015 at 06:54:25 PM by saroyanm

Press releases (English)

comment:3 Changed on 12/02/2015 at 06:55:54 PM by saroyanm

  • Description modified (diff)

comment:4 follow-up: Changed on 12/02/2015 at 07:13:57 PM by saroyanm

Add two sections "English" and "German" - one after the other - and deep-link to them from the top of the tab content

We do not have TOC implemented for the eyeo.com, not sure if it's really necessary on current stage, because it won't look nice IMO, also people will not be able to share the link, even to the press page I do not mind to tackle this issue within current ticket, but maybe we can leave it for later on because of tight schedule.

comment:5 in reply to: ↑ 4 Changed on 12/02/2015 at 07:29:44 PM by greiner

Replying to saroyanm:

We do not have TOC implemented for the eyeo.com, not sure if it's really necessary on current stage, because it won't look nice IMO, also people will not be able to share the link, even to the press page I do not mind to tackle this issue within current ticket, but maybe we can leave it for later on because of tight schedule.

The links can be added manually. There's no need to go through the trouble of adding support for automated creation of a table of contents.

The idea behind it is that visitors see - independent of how long the list of press releases is - that there are press releases in different languages without having to discover it by scrolling past the English press releases. However, if there's consent that the list titles (namely "English" and "German") are already a good indicator for that we can skip that one.

Changed on 12/03/2015 at 10:50:25 AM by saroyanm

long titles

comment:6 follow-up: Changed on 12/03/2015 at 10:53:28 AM by saroyanm

@ben don't you mind if I'll use short names for some titles ? ex.:
Adblock Plus Builds First Mobile Browser From the Ground Up and First Free Ad Blocker on the Apple App Store Arrives
So they will look better on desktop version of the website (see screenshot)

Last edited on 12/03/2015 at 10:53:56 AM by saroyanm

comment:7 in reply to: ↑ 6 ; follow-up: Changed on 12/03/2015 at 11:18:52 AM by greiner

Replying to saroyanm:

@ben don't you mind if I'll use short names for some titles ? ex.:
Adblock Plus Builds First Mobile Browser From the Ground Up and First Free Ad Blocker on the Apple App Store Arrives
So they will look better on desktop version of the website (see screenshot)

I'd suggest that those titles should rather create a second line. Thereby we could also ensure forwards-compatibility.

comment:8 in reply to: ↑ 7 Changed on 12/03/2015 at 11:22:45 AM by saroyanm

Replying to greiner:

Replying to saroyanm:

@ben don't you mind if I'll use short names for some titles ? ex.:
Adblock Plus Builds First Mobile Browser From the Ground Up and First Free Ad Blocker on the Apple App Store Arrives
So they will look better on desktop version of the website (see screenshot)

I'd suggest that those titles should rather create a second line. Thereby we could also ensure forwards-compatibility.

Okey, in that case I will suggest create second line on desktop and have new line for smaller screens.

Changed on 12/03/2015 at 11:42:41 AM by saroyanm

comment:9 follow-up: Changed on 12/03/2015 at 11:44:37 AM by saroyanm

Just uploaded screenshot for both versions on mobile Iphone4 I guess both looks okey, so IMO we can have multi line for the titles on mobile as well. Just will add small bottom margin.

Last edited on 12/03/2015 at 11:46:19 AM by saroyanm

comment:10 in reply to: ↑ 9 ; follow-up: Changed on 12/03/2015 at 11:49:28 AM by greiner

Replying to saroyanm:

Just uploaded screenshot for both versions on mobile Iphone4 I guess both looks okey, so IMO we can have multi line for the titles on mobile as well. Just will add small bottom margin.

Let's go with the one on the right side in the screenshot because it looks cleaner and is much more flexible in regards to varying screen sizes.

comment:11 in reply to: ↑ 10 Changed on 12/03/2015 at 12:53:15 PM by ben

Replying to greiner:

Replying to saroyanm:

Just uploaded screenshot for both versions on mobile Iphone4 I guess both looks okey, so IMO we can have multi line for the titles on mobile as well. Just will add small bottom margin.

Let's go with the one on the right side in the screenshot because it looks cleaner and is much more flexible in regards to varying screen sizes.

Agreed.

@saroyanm, I also agree that the shortened headlines are better. Let me know if you have any questions as to how to shorten them.

comment:12 Changed on 12/03/2015 at 02:07:44 PM by ben

Small change:

In the Google Drive folder with all the PDFs, I removed one document entitled "2013_8-13_ABP-for-IE_POST"
and added another one: "15-01-27 - Maxthon - US - WEB."

comment:13 follow-up: Changed on 12/07/2015 at 03:38:31 PM by saroyanm

Hey @Ben what is the status of the German PDFs ?

comment:14 in reply to: ↑ 13 Changed on 12/07/2015 at 03:42:00 PM by ben

Replying to saroyanm:

Hey @Ben what is the status of the German PDFs ?

They're in teh same Drive folder. The English ones are in the folder named "EN" and the German ones in the folder labeled "DE."

https://drive.google.com/drive/u/0/folders/0B8lYM5symyZjZmVmcm1iVHdYVkU

Changed on 12/07/2015 at 03:52:36 PM by saroyanm

Press releases (English)

comment:15 Changed on 12/07/2015 at 03:53:09 PM by saroyanm

  • Description modified (diff)

Changed on 12/07/2015 at 03:54:09 PM by saroyanm

Press releases (German)

comment:16 Changed on 12/07/2015 at 03:59:44 PM by saroyanm

  • Description modified (diff)

comment:17 Changed on 12/07/2015 at 04:02:38 PM by saroyanm

  • Owner set to saroyanm
  • Priority changed from Unknown to P2
  • Ready set

comment:18 Changed on 12/07/2015 at 05:26:56 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:19 Changed on 12/15/2015 at 01:15:41 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.