Opened on 12/09/2015 at 08:08:56 AM
Closed on 12/18/2015 at 09:30:04 AM
Last modified on 01/20/2016 at 03:07:47 PM
#3395 closed change (fixed)
Support new filter list structure containing meta data
| Reported by: | mario | Assignee: | jand |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-iOS-1.1.0 |
| Module: | Adblock-Plus-for-iOS/macOS | Keywords: | salsita |
| Cc: | Blocked By: | ||
| Blocking: | #3177 | Platform: | iOS |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://github.com/adblockplus/adblockplussafariios/pull/16 |
||
Description (last modified by mario)
Background
#3176 introduces meta data to all of our filter lists. This meta data will be served for iOS filter lists as well. Please consult #3176 for the new data structure. In order to be able to still perform automatic filter list updates (introduced by #3093) the new data structure needs to be supported.
Please note, that this issue only introduces the capability to load and process the new data structure on top of the old data structure. The handling of meta data is covered by #3177.
Example files with the new data structure.
What to change
On top of the currently used filter list data structure provide support for the new filter list data structure introduced by #3176.
Remark for testers
This functionality can be tested by tapping "Update Filter List" in the app's settings. Please note, that - in order to fully test this change - a new list with the new data structure needs to be provided to the app by our backend.
Attachments (1)
Change History (9)
Changed on 12/09/2015 at 08:09:20 AM by mario
comment:2 Changed on 12/09/2015 at 08:11:15 AM by mario
- Blocking 3177 added
comment:3 Changed on 12/10/2015 at 02:11:20 PM by jand
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from new to closed
comment:4 Changed on 12/15/2015 at 05:48:16 PM by fhd
- Resolution fixed deleted
- Status changed from closed to reopened
Please don't close issues that haven't landed yet.
comment:5 Changed on 12/15/2015 at 05:48:33 PM by fhd
- Owner set to jand
comment:6 Changed on 12/15/2015 at 05:49:15 PM by fhd
- Milestone set to Adblock-Plus-for-iOS-1.1.0
- Ready set
- Status changed from reopened to reviewing
comment:7 Changed on 12/18/2015 at 09:30:04 AM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 01/20/2016 at 03:07:47 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Tested updating lists before and after asking Felix to update it to the new format on the server and everything appears to be working correctly.
ABP for iOS 1.0.1 (201601191812)
iPhone 5S / iOS 9.2
Mario: Testing of filter list processing is partially covered by unit tests.