Opened on 12/14/2015 at 01:59:01 PM

Last modified on 12/14/2015 at 02:15:26 PM

#3409 new change

Make sure ABP for IE extracts the URL of the HTML OBJECT tag correctly

Reported by: oleksandr Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

We are extracting the URL of the HTML OBJECT tag in AdblockPlusDomTraverser.cpp. We are currently assuming IE will always give us an uppercase string on input, but it looks like most recent IE version does not do HTML normalization.
The relevant code is int posBegin = sObjectHtml.Find(L"VALUE=\"");

What to change

Fix the URL extraction to support both lower and upper case characters.

Attachments (0)

Change History (1)

comment:1 Changed on 12/14/2015 at 02:15:26 PM by oleksandr

  • Cc oleksandr added; AdelaideODoherty removed

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.