Opened on 12/16/2015 at 11:03:40 AM
Closed on 12/16/2015 at 11:16:19 AM
#3419 closed change (fixed)
Update buildtools dependency for Diagnostics to revision f3c4a535f1c7
Reported by: | trev | Assignee: | trev |
---|---|---|---|
Priority: | P3 | Milestone: | Diagnostics-1.3.1-for-Adblock-Plus |
Module: | Extensions-for-Adblock-Plus | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Firefox | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Background
#3418 and #3260 take care of warnings that are currently showing up in Firefox 45. #2897 makes sure that development builds no longer have an update URL (using the default which is pointing to AMO). #3194 and #2972 are improvements to the ensure_dependencies.py script. There is also a number of changes not affecting builds for this extension (#2509, #2607, #2665, #2763, #2711, #2796, #2968, #3002, #3017, #3039, #3039, #3344, #3345, #3415).
What to change
Updating dependency and running ensure_dependencies.py should be sufficient.
What to test
The extension and its preference (extensions.abpwatcher.startwatching_key) should still work.
Attachments (0)
Change History (1)
comment:1 Changed on 12/16/2015 at 11:16:19 AM by trev
- Milestone set to Diagnostics-for-Adblock-Plus-next
- Resolution set to fixed
- Status changed from new to closed
Fixed: https://hg.adblockplus.org/abpwatcher/rev/b1e1a6e1988d