Opened on 12/16/2015 at 01:13:01 PM
Closed on 12/17/2015 at 10:59:01 AM
#3424 closed change (fixed)
Update buildtools dependency for URL Fixer to revision b02d0532e33c
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | URL-Fixer-4.1.1 |
| Module: | URL-Fixer | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
#3418, #3260, #3421 and #1434 take care of warnings that are currently showing up in Firefox 45. #2897 makes sure that development builds no longer have an update URL (using the default which is pointing to AMO). #3194 and #2972 are improvements to the ensure_dependencies.py script. There is also a number of changes not affecting builds for this extension (#2509, #2607, #2665, #2763, #2711, #2796, #2968, #3002, #3017, #3039, #3039, #3344, #3345, #3415).
What to change
Updating dependency and running ensure_dependencies.py should be sufficient. I also want to add some tests for hooks.js in buildtools however, the logic there is rather complicated.
What to test
The extension and its preferences (e.g. the domain whitelist) should still work.
Attachments (0)
Change History (2)
comment:1 Changed on 12/16/2015 at 01:17:46 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/17/2015 at 10:59:01 AM by trev
- Milestone set to URL-Fixer-next
- Resolution set to fixed
- Status changed from reviewing to closed
- Summary changed from Update buildtools dependency for URL Fixer to revisoin b02d0532e33c to Update buildtools dependency for URL Fixer to revision b02d0532e33c
Done: https://hg.adblockplus.org/urlfixer/rev/32f69488c197