Opened on 12/17/2015 at 02:42:34 PM

Closed on 12/23/2015 at 12:53:07 PM

#3431 closed defect (fixed)

Element Hiding Helper shutdown fails ("shutdown is not a function")

Reported by: trev Assignee: trev
Priority: P1 Milestone: Element-Hiding-Helper-1.3.6
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29332893/

Description

Environment

Element Hiding Helper 1.3.5.515-beta
Firefox 46.0a1 with multi-process enabled

How to reproduce

  1. Open Addons Manager.
  2. Disable Element Hiding Helper.

Observed behaviour

"TypeError: shutdown is not a function" error thrown in frameScript.js line 21.

Expected behaviour

No errors.

Attachments (0)

Change History (3)

comment:1 Changed on 12/21/2015 at 12:20:26 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

I fixed the immediate symptoms but created #3443 for the proper solution.

comment:2 Changed on 12/21/2015 at 12:20:33 PM by trev

  • Owner set to trev

comment:3 Changed on 12/23/2015 at 12:53:07 PM by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/elemhidehelper/rev/6f732d106100

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.