Opened on 12/21/2015 at 04:05:31 PM
Closed on 12/21/2015 at 04:09:45 PM
Last modified on 01/18/2016 at 08:59:32 AM
#3447 closed change (fixed)
Update buildtools dependency for Adblock Plus to revision b02d0532e33c
Reported by: | trev | Assignee: | trev |
---|---|---|---|
Priority: | P3 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
Module: | Adblock-Plus-for-Firefox | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Platform: | Firefox | |
Ready: | yes | Confidential: | no |
Tester: | Ross | Verified working: | yes |
Review URL(s): |
Description
Background
#3418, #3421 and #1434 take care of warnings that are currently showing up in Firefox 45. There is also some changes not affecting builds for this extension (#3344, #3345, #3415).
What to change
Updating dependency and running ensure_dependencies.py should be sufficient.
What to test
The extension and its preferences (especially shortcut keys) should still work.
Attachments (0)
Change History (2)
comment:1 Changed on 12/21/2015 at 04:09:45 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed on 01/18/2016 at 08:59:32 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
No warnings seen in console and extension/preferences seem to be working correctly.
ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 45 / 46.0a1 / Ubuntu 14.04 x64
Note: See
TracTickets for help on using
tickets.
Done: https://hg.adblockplus.org/adblockplus/rev/60442888ebc1