Opened on 01/04/2016 at 02:17:31 PM

Closed on 01/04/2016 at 02:40:24 PM

#3463 closed defect (fixed)

Filtering broken in Diagnostics

Reported by: trev Assignee: trev
Priority: P1 Milestone: Diagnostics-1.3.1-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: #3420 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29333128/

Description

Environment

Diagnostics 1.3.0.254 in Firefox 46.0a1 nightly.

How to reproduce

  1. Open Diagnostics window.
  2. Enter something into the Filter field and press Enter.

Observed behaviour

List isn't filtered, instead "TypeError: entry.cols is not iterable watcher.js:413:16" appears in the Error Console.

Expected behaviour

List is filtered.

Attachments (0)

Change History (3)

comment:1 Changed on 01/04/2016 at 02:17:57 PM by trev

  • Blocking 3420 added

This appears to be a regression from #3420.

comment:2 Changed on 01/04/2016 at 02:22:51 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 01/04/2016 at 02:40:24 PM by trev

  • Milestone set to Diagnostics-for-Adblock-Plus-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/abpwatcher/rev/edd4cd94360e

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.