Opened on 01/12/2016 at 05:05:51 PM

Closed on 01/12/2016 at 06:06:00 PM

Last modified on 01/18/2016 at 01:32:55 AM

#3505 closed change (fixed)

Issue reporter calls String.replace() with deprecated flags parameter

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.7.1-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29333409/

Description

Background

Issue reporter calls String.replace() with a string to replace and "gi" as flags parameter. The flags parameter is deprecated however and causes a warning in Firefox 46.0a1.

What to change

Convert the string into a proper regular expression, so that no flags have to be passed to String.replace().

Attachments (0)

Change History (4)

comment:1 Changed on 01/12/2016 at 05:07:31 PM by trev

  • Summary changed from Issue reporter uses deprecacted flags parameter to String.replace() to Issue reporter calls String.replace() with deprecated flags parameter

comment:2 Changed on 01/12/2016 at 05:08:09 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 01/12/2016 at 06:06:00 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/4e869de0f38b

comment:4 Changed on 01/18/2016 at 01:32:55 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

No warning appears in the Firefox console.

ABP 2.7.0.4128-beta
Firefox 46.0a1 / Ubuntu 14.04 x64

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.