Opened on 01/22/2016 at 09:34:31 AM
Closed on 07/27/2017 at 06:31:12 PM
#3561 closed defect (fixed)
Test FilterEngineTest, SetRemoveFilterChangeCallback in libadblockplus is failed
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | fhd, asmirnov | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Win 32 and *nix
How to reproduce
Compile and run tests.
Observed behaviour
The output is
... [ RUN ] FilterEngineTest.SetRemoveFilterChangeCallback ..\..\test\FilterEngine.cpp(387): error: Value of: timesCalled Actual: 3 Expected: 2 ..\..\test\FilterEngine.cpp(391): error: Value of: timesCalled Actual: 3 Expected: 2 [ FAILED ] FilterEngineTest.SetRemoveFilterChangeCallback (204 ms)
Expected behaviour
The test should pass.
Additional note
There is a race condition, adding of AdblockPlus::Sleep(40/*msec*/); at the beginning of the test body helps.
Attachments (0)
Change History (5)
comment:1 Changed on 05/17/2016 at 02:17:22 PM by sergz
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from new to closed
comment:2 Changed on 11/29/2016 at 12:35:21 PM by sergz
- Resolution fixed deleted
- Status changed from closed to reopened
comment:3 Changed on 11/29/2016 at 12:43:24 PM by asmirnov
- Cc Anton added
comment:4 Changed on 03/23/2017 at 12:46:09 PM by sergz
- Cc asmirnov added; Anton removed
comment:5 Changed on 07/27/2017 at 06:31:12 PM by sergz
- Resolution set to fixed
- Status changed from reopened to closed
Note: See
TracTickets for help on using
tickets.
The test fails again, there is still a race condition, however the reason can be different from the previous case.
[ RUN ] FilterEngineTest.SetRemoveFilterChangeCallback ..\..\test\FilterEngine.cpp(501): error: Expected: 1 To be equal to: timesCalled Which is: 2 ..\..\test\FilterEngine.cpp(505): error: Expected: 1 To be equal to: timesCalled Which is: 2