Opened on 02/01/2016 at 10:00:31 AM

Closed on 05/04/2017 at 03:16:06 PM

Last modified on 06/19/2017 at 12:31:09 PM

#3598 closed change (fixed)

Change the permission point in android FAQ page on [adblockbrowser.org]

Reported by: saroyanm Assignee: juliandoucette
Priority: P2 Milestone:
Module: Websites Keywords:
Cc: Shikitita, lisabielik, philll, rjeschke, Anton, annlee@…, diegocarloslima Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29362492/

Description (last modified by saroyanm)

Background

Current Why does Adblock Browser for Android require so many permissions? section on android FAQ page needs to be changed to provide better insight to user about each permission the ABB for Android requires.

What to change

Update the Why does Adblock Browser for Android require so many permissions? section on current page with the text from current document.

Attachments (0)

Change History (30)

comment:1 Changed on 02/01/2016 at 10:07:17 AM by saroyanm

  • Description modified (diff)

comment:2 Changed on 02/01/2016 at 10:09:46 AM by saroyanm

  • Component changed from Unknown to Websites
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed on 02/01/2016 at 10:10:35 AM by saroyanm

  • Cc Shikitita added

comment:4 Changed on 02/01/2016 at 12:40:30 PM by philll

  • Ready unset

The provided Text doesn't take Android 6 into account, where permissions are requested when trying to be used first time. Also, the texts don't explain at all in most cases what those permissions are commonly used for by a use case a user would understand.

comment:5 Changed on 02/01/2016 at 12:49:31 PM by saroyanm

  • Cc annlee@… lisabielik added

@Ann-Lee, @Lisa I think make sense to made the document editable again, address all the complains and seems like unfortunately the translations needs to be revisited after that if there are big changes, hopefully we can avoid that.
@Lisa can you please check if you are the owner of document and make it editable by Eyeo team.

comment:6 follow-up: Changed on 02/01/2016 at 05:27:14 PM by lisabielik

@saroyanm

I changed the permissions - anyone at Eyeo should be able to edit:

https://docs.google.com/document/d/1kK052oEtIKG_4yxOzAlDuSJ5DG8VocZ1KwMjyaIaw6w/edit

comment:7 in reply to: ↑ 6 Changed on 02/02/2016 at 09:37:27 AM by saroyanm

Replying to lisabielik:

@saroyanm

I changed the permissions - anyone at Eyeo should be able to edit:

https://docs.google.com/document/d/1kK052oEtIKG_4yxOzAlDuSJ5DG8VocZ1KwMjyaIaw6w/edit

Thanks, @Phill can you please provide suggestions in the document itself.

Please note that the current text is already has been translated so I think maybe make sense to mark the suggestions to make it easier for @Tamara to see all the changes, not to search through all historyline.

comment:8 Changed on 02/02/2016 at 11:53:57 AM by saroyanm

  • Cc philll added
  • Sensitive set

I just marked the ticket confidential, but will change the permission after all the drive document will be again available for public after discussions under the drive document.

comment:9 Changed on 02/02/2016 at 11:54:09 AM by saroyanm

  • Cc philll added
  • Sensitive set

I just marked the ticket confidential, but will change the permission after the drive document will be again available for public after discussions under the drive document.

comment:10 Changed on 02/02/2016 at 02:33:06 PM by saroyanm

  • Sensitive unset

Rolling back to public, because of no reason to keep it confidential.

comment:11 Changed on 06/17/2016 at 03:40:13 PM by juliandoucette

5 months is a long time for such a small change.

Where do we stand on this @phill, @lisabielik, @annlee ?

comment:12 Changed on 06/17/2016 at 03:43:34 PM by philll

  • Cc rjeschke added

We're waiting for Rjeschke to share his knowledge on the linked document. Once we know whether the suggested texts apply to reality, we can put them into the ticket description and start implementing them.

comment:13 Changed on 09/27/2016 at 02:40:23 PM by juliandoucette

Can anyone else unblock this?

rjeschke seems to be MIA.

comment:14 Changed on 09/28/2016 at 08:59:21 AM by philll

  • Cc Anton added

@Anton: Could you please have a look at the linked document with the new texts and comment whether the explanations match reality? Specifically the part about the "Identity" permission seems still unclear.

comment:15 Changed on 10/07/2016 at 05:12:59 PM by juliandoucette

  • Cc diegocarloslima added

From Anton:

I think you'd better forward the question to Diego (CCed), since he's working mostly on abbrowser and i'm still working on library.

@diegocarloslima do you have any thoughts?

comment:16 Changed on 10/13/2016 at 10:32:23 PM by diegocarloslima

@juliandoucette, @phill, @lisabielik, I've added some comments to the document

comment:17 Changed on 11/07/2016 at 07:04:54 PM by juliandoucette

  • Priority changed from P2 to Unknown

Thanks @diegocarloslima. Is this ready now @lisabielik?

comment:18 Changed on 11/07/2016 at 08:29:10 PM by lisabielik

Waiting to see if the 'Identity' permission has been removed. If it has, then the text is ready (just exclude the 'Identity' description).

@diegocarloslima, can you confirm?

For reference: https://docs.google.com/document/d/1kK052oEtIKG_4yxOzAlDuSJ5DG8VocZ1KwMjyaIaw6w/edit

comment:19 Changed on 11/08/2016 at 10:57:14 AM by diegocarloslima

@juliandoucette, @lisabielik, I've added comments regarding that in the doc, but in short, we should keep the Identity permission section for now.

comment:20 Changed on 11/08/2016 at 02:58:41 PM by lisabielik

comment:21 Changed on 11/11/2016 at 07:09:52 PM by juliandoucette

  • Priority changed from Unknown to P2
  • Ready set

comment:22 Changed on 11/11/2016 at 07:15:50 PM by juliandoucette

  • Owner set to juliandoucette

comment:23 Changed on 11/11/2016 at 07:34:57 PM by juliandoucette

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:24 Changed on 11/14/2016 at 02:13:37 PM by Shikitita

I have the information ready for the translation agency together with the source text. If there is no inconvenient or concerns from anyone, I'll go ahead and request the project.

comment:25 Changed on 12/06/2016 at 04:51:06 PM by Shikitita

@Julian: I've already received the translations for the final English text and they should be ready for implementation. I'm guessing this should be done through Crowdin once the new English strings are added?

comment:26 Changed on 02/22/2017 at 06:03:14 PM by jeen

@juliandoucette: what's the latest on this?

Last edited on 02/22/2017 at 06:03:44 PM by jeen

comment:27 Changed on 02/22/2017 at 09:01:44 PM by juliandoucette

@juliandoucette: what's the latest on this?

According to the latest review by saroyanm I have a couple trivial updates to make.

comment:28 Changed on 05/03/2017 at 04:28:58 PM by abpbot

A commit referencing this issue has landed:
Issue 3598 - Updated permissions section of android FAQ

comment:29 Changed on 05/04/2017 at 03:16:06 PM by juliandoucette

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:30 Changed on 06/19/2017 at 12:31:09 PM by abpbot

A commit referencing this issue has landed:
Issue 3598 - Synced translations for android support faq

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from juliandoucette.
 
Note: See TracTickets for help on using tickets.