Opened on 02/10/2016 at 06:31:32 PM
Closed on 02/22/2016 at 05:35:53 PM
Last modified on 03/04/2016 at 01:59:17 PM
#3649 closed change (fixed)
Replace notification download counts above 4 with a range in uninstallation page
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.11-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | greiner, sebastian, saroyanm, Kirill | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by kzar)
Background
There is an uninstallation page that is shown when the Chrome / Opera extension is uninstalled. When the page is loaded several pieces of data are sent as query parameters.
The page contains a form asking the user for feedback as to why they uninstalled the extension. When submitted their feedback is sent to us, combined with the data included in the query parameters.
(It's worth noting that our web server will still see the data parameters even if the user does not submit any feedback. Therefore it's important that we consider user privacy when deciding which parameters to include.)
What to change
Values of notificationDownloadCount above 4 should be replaced with a range before being passed to the uninstallation page. The groupings are as follows:
0, 1, 2, 3, 4, 5-7, 8-29, 30-89, 90-179, 180+
For each of the groupings the parameter's value will be the corresponding string:
"0", "1", "2", "3", "4", "5-7", "8-29", "30-89", "90-179", "180+"
Note: This change needs to be made in adblockpluschrome/lib/uninstall.js.
Attachments (0)
Change History (13)
comment:2 Changed on 02/11/2016 at 09:49:35 AM by saroyanm
- Cc saroyanm added
comment:3 Changed on 02/11/2016 at 02:35:58 PM by kzar
comment:4 Changed on 02/11/2016 at 02:37:48 PM by fhd
comment:5 Changed on 02/11/2016 at 02:41:07 PM by kzar
- Description modified (diff)
We can't easily update the dependency at the moment as that is blocked by the adblockpluscore switch. Therefore I vote we fix it here as well as a stop gap in the mean time.
comment:8 Changed on 02/15/2016 at 11:19:54 AM by Kirill
- Cc Kirill added
comment:9 Changed on 02/22/2016 at 03:35:45 PM by kzar
- Description modified (diff)
- Sensitive set
- Status changed from reviewing to reopened
- Summary changed from Replace notification download counts of >=4 with "4+" in uninstallation page to Replace notification download counts above 4 with a range in uninstallation page
comment:10 Changed on 02/22/2016 at 03:43:03 PM by kzar
- Review URL(s) modified (diff)
comment:11 Changed on 02/22/2016 at 03:49:41 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:12 Changed on 02/22/2016 at 03:59:37 PM by kzar
- Sensitive unset
comment:13 Changed on 02/22/2016 at 04:31:11 PM by kzar
- Description modified (diff)
comment:14 Changed on 02/22/2016 at 05:14:31 PM by kzar
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:15 Changed on 02/22/2016 at 05:35:53 PM by kzar
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:16 Changed on 03/03/2016 at 10:44:41 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Implemented and working as expected.
ABP 1.10.2.1558
Chrome 30 / Windows 7 x86
Chrome 47 / Windows 7 x86
Chrome 48 / Ubuntu 14.04 x64
Opera 19 / Windows 7 x86
Opera 35 / Windows 7 x86
Opera 35 / Ubuntu 14.04 x64
I think it's better to fix #3650 instead and close this one. Plus, we shouldn't land this yet, we have yet to agree on this.