Opened on 02/23/2016 at 04:24:10 PM
Closed on 02/23/2016 at 04:39:34 PM
Last modified on 03/08/2016 at 11:49:07 AM
#3685 closed change (fixed)
Remove dead migration code from subscription initilization
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.11-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
We still run some migration code, removing the outdated https://easylist-downloads.adblockplus.org/chrome_supplement.txt subscription, and adding the Anti-Adblock list when migrating from before Adblock Plus 1.8.
That migration code not only has been in there for long enough, but also it's essentially dead code now as with #3446 no data are migrated at all when updating from a version older than Adblock Plus 1.9.
What to change
Remove the migration code, that removes the https://easylist-downloads.adblockplus.org/chrome_supplement.txt subscription and adds the Anti-Adblock list.
Attachments (0)
Change History (3)
comment:1 Changed on 02/23/2016 at 04:25:59 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 02/23/2016 at 04:39:34 PM by sebastian
- Milestone set to Adblock-Plus-1.11-for-Chrome-Opera-Safari
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 03/08/2016 at 11:49:07 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Subscriptions still work / are added on install.
ABP 1.10.2.1559
Chrome 30 / Windows 7 x86
Chrome 47 / Windows 7 x86
Chrome 48 / Ubuntu 14.04 x64
Opera 19 / Windows 7 x86
Opera 35 / Windows 7 x86
Opera 35 / Ubuntu 14.04 x64
Safari 6 (OS X 10.8) / Safari 8 (OS X 10.10) / Safari 9 (OS X 10.11)
https://hg.adblockplus.org/adblockpluschrome/rev/d2bcde84cf89