Opened on 02/25/2016 at 02:54:38 PM

Closed on 11/10/2017 at 11:15:18 AM

Last modified on 10/08/2019 at 05:46:07 PM

#3702 closed defect (rejected)

Adblock Plus sometimes tries to access undefined properties after shutdown

Reported by: sergz Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by trev)

Environment

Mozilla Firefox 44.0.2
Adblock Plus 2.7.2

How to reproduce

  1. Install Adblock Plus
  2. Disable it via Add-ons Manager.

Observed behaviour

Error messages in Browser Console:

Full message: TypeError: require is not a function
Full stack: exports.Utils.yield@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/utils.js:354:19
INIParser.prototype.process@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/filterStorage.js:798:7
exports.IO.readFromFile/onProgress@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/io.js:97:15
exports.IO.readFromFile/<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/io.js:182:11
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:1

Full message: TypeError: Cu is null
Full stack: exports.FilterStorage.loadFromDisk/readFile</<@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/filterStorage.js:380:11
exports.IO.readFromFile/onError@resource://gre/modules/addons/XPIProvider.jsm -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///tmp/tmpNal4NH.mozrunner/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/io.js:149:9
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:21
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7
this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:1

Expected behaviour

It should gracefully shutdown.

Additional notes

The io module is still triggering callbacks after the extension is shut down. It should check onShutdown.done for any async processing.

Attachments (0)

Change History (7)

comment:1 Changed on 03/15/2016 at 09:37:45 AM by trev

  • Cc trev added
  • Description modified (diff)
  • Keywords crawler removed
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from ABP for firefox tries to access undefined properties on shutdown in crawler to Adblock Plus sometimes tries to access undefined properties after shutdown

This is a cosmetic problem, not only affecting crawler however. I've adjusted the description accordingly.

comment:2 Changed on 11/10/2017 at 11:15:18 AM by trev

  • Resolution set to rejected
  • Status changed from new to closed

Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.

comment:3 Changed on 03/15/2019 at 06:16:19 AM by takken3

spam

Last edited on 10/08/2019 at 05:45:55 PM by kzar

comment:4 Changed on 05/19/2019 at 02:52:11 AM by SharrySteve1

spam

Last edited on 10/08/2019 at 05:45:58 PM by kzar

comment:5 Changed on 07/25/2019 at 05:25:31 AM by SharrySteve1

spam

Last edited on 10/08/2019 at 05:46:01 PM by kzar

comment:6 Changed on 08/16/2019 at 12:41:58 PM by Munna123

spam

Last edited on 10/08/2019 at 05:46:04 PM by kzar

comment:7 Changed on 10/06/2019 at 10:08:46 AM by Mary31

spam

Last edited on 10/08/2019 at 05:46:07 PM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.