Opened on 02/25/2016 at 10:34:24 PM
Closed on 05/23/2016 at 05:21:21 AM
Last modified on 09/23/2017 at 02:53:38 PM
#3705 closed change (fixed)
Don't rely on info.platform when checking for availability of the chrome.* API
| Reported by: | sebastian | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | scottlow | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
With #3704, info.platform will be set to "edge" (instead "chromium") when running on Edge. However, some of the code in Adblock Plus assumes that info.platform == "chromium" indicates the availability of the Chrome extension API. This however, is no longer be true.
What to change
Adapt the checks relying on info.platform in webRequest.js, lib/prefs.js, and lib/notificationHelper.js to check for availability of the chrome namespace instead.
Attachments (0)
Change History (7)
comment:1 Changed on 03/17/2016 at 07:11:19 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 05/07/2016 at 01:32:41 AM by sebastian
- Cc scottlow added
comment:3 Changed on 05/23/2016 at 05:21:21 AM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/23/2016 at 10:36:25 AM by sebastian
- Keywords edge removed
- Platform changed from Unknown / Cross platform to Edge
comment:5 Changed on 06/10/2016 at 11:27:49 PM by sebastian
- Sensitive unset
comment:6 Changed on 11/08/2016 at 12:24:21 PM by abpbot
comment:7 Changed on 09/23/2017 at 02:53:38 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Marking this as verified for the milestone. Notifications don't seem to work in Edge (#5746) but appear on other platforms. Will follow that up later.
ABP 0.9.11.1849
Edge 40 / Windows 10
ABP 1.13.3.1838
Chrome 49 / 61 / Windows 10
Opera 36 / 47 / Windows 10
A commit referencing this issue has landed:
Issue 3705 - Don't rely on info.platform when checking for availability of the...