Opened on 03/09/2016 at 09:50:31 AM
Closed on 03/14/2016 at 02:27:53 PM
Last modified on 03/21/2016 at 12:40:56 PM
#3764 closed change (fixed)
Redirect adblockplus(chrome|chrome-experimental|opera)/updates.xml to CWS
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29338013/ |
||
Description
Background
We still have some development build users requesting updates.xml on our downloads server even though the builds moved to Chrome Web Store. This is especially true for Opera users, there the development builds used our update infrastructure until recently.
What to change
Redirect adblockplus(chrome|chrome-experimental|opera)/updates.xml to https://clients2.google.com/service/update2/crx (keep query string) on the downloads server.
Attachments (0)
Change History (12)
comment:1 Changed on 03/09/2016 at 10:00:51 AM by trev
- Owner set to trev
comment:2 Changed on 03/09/2016 at 10:52:23 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 03/09/2016 at 11:07:07 AM by sebastian
- Cc sebastian added
comment:4 Changed on 03/09/2016 at 01:51:33 PM by abpbot
comment:5 Changed on 03/09/2016 at 04:10:38 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
This change is active on all servers now.
comment:6 Changed on 03/14/2016 at 10:57:29 AM by Ross
I previously looked at this and it was working as expected. Looking at it again it's working but it's duplicating the query params, is that intended?
https://downloads.adblockplus.org/devbuilds/adblockplusopera/updates.xml?queryp=test
seems to be rewritten to
https://clients2.google.com/service/update2/crx?queryp=test&queryp=test
comment:7 Changed on 03/14/2016 at 10:59:15 AM by sebastian
That is not intended. It seems that the $query_string in the rewrite rule is redundant.
comment:8 Changed on 03/14/2016 at 11:41:37 AM by trev
- Ready set
- Resolution fixed deleted
- Status changed from closed to reopened
I was under the impression that Nginx wouldn't append query parameters if a query string is present. However, looking into the examples under http://nginx.org/en/docs/http/ngx_http_rewrite_module.html#rewrite - I was wrong, you still have a put ? at the end in order to suppress them.
comment:9 Changed on 03/14/2016 at 02:23:50 PM by trev
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:10 Changed on 03/14/2016 at 02:24:40 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/37cfd64066a0
comment:11 Changed on 03/14/2016 at 02:27:53 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Fixed again.
comment:12 Changed on 03/21/2016 at 12:40:56 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
The query parameters and redirect now behave as expected.
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/fccf07122bf4