Opened on 03/09/2016 at 02:23:12 PM
Closed on 07/05/2017 at 08:13:47 AM
#3769 closed defect (fixed)
UI colours gone bad
| Reported by: | rjeschke | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
We need to exhaustively test the changes Mozilla did to the UI and its colours.
First issue is already the new search screen (see attached image).
The style guide of ABB can be found here: https://drive.google.com/drive/u/0/folders/0BwuqgB4SCPsPfjdFV19NU1pTRE5ZaFpjd3AzZlo4c2RtV0U0dHYzVTlIUDZGcEpUTHhhWUU
Attachments (10)
Change History (19)
Changed on 03/09/2016 at 02:23:51 PM by rjeschke
comment:1 Changed on 07/11/2016 at 11:07:15 PM by diegocarloslima
- Owner set to diegocarloslima
comment:2 Changed on 08/24/2016 at 10:40:27 AM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 12/01/2016 at 05:06:03 PM by fhd
Can you please attach the style guide to the issue?
Changed on 12/01/2016 at 05:12:55 PM by diegocarloslima
Changed on 12/01/2016 at 05:13:06 PM by diegocarloslima
Changed on 12/01/2016 at 05:13:18 PM by diegocarloslima
Changed on 12/01/2016 at 05:13:28 PM by diegocarloslima
Changed on 12/01/2016 at 05:13:58 PM by diegocarloslima
comment:5 Changed on 12/12/2016 at 02:33:41 PM by abpbot
A commit referencing this issue has landed:
Issue 3769 - UI colours gone bad
comment:6 Changed on 12/12/2016 at 02:36:16 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 06/20/2017 at 08:37:42 AM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
- Tester changed from Unknown to Scheer
In colours 4.png the mask for private mode is purple, but in the latest build it is grey with a whiled next to it. It would be quite hard to confirm these changes are correct without an up-to-date style guide to reflect the correct intended changes here. As for the main issue shown in the first screenshot (grey-on-grey.png) this no longer occurs, but as there was no device specified, I can only confirm that particular fix on a Galaxy S7, Android 7.0. Could we update this ticket with an explanation or new style guides so I can confirm that the correct UI colours are shown across the areas of concern, or maybe just a screenshot of the currently known areas that *were* broken?
comment:8 Changed on 06/30/2017 at 04:56:58 PM by diegocarloslima
Our style guide was made based on Firefox 40.0, so some icons have changed in Firefox 44.0.2. The private mask icon is one of them, Mozilla changed it from a purple icon to a grey one. Since we don't have a detailed style guide that is based on Firefox 44.0.2 and many stuff changed, I had to do my best interpretation of the old guide and only changed what I considered that was relevant (mostly removing orange stuff, that doesn't belongs to our color palette). I'll attach some screenshots of mostly what was 'wrong' and how it was changed. My opinion is that once we have a more detailed style guide, we might revisit the icons/colors again and make the appropriate changes.
Changed on 06/30/2017 at 06:38:19 PM by diegocarloslima
Changed on 06/30/2017 at 06:38:30 PM by diegocarloslima
Changed on 06/30/2017 at 06:38:49 PM by diegocarloslima
Changed on 06/30/2017 at 06:42:25 PM by diegocarloslima
comment:9 Changed on 07/05/2017 at 08:13:47 AM by scheer
- Resolution set to fixed
- Status changed from reopened to closed
- Verified working set
- As mentioned, all colours are now displayed correctly.
adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
The new search screen