Opened on 03/14/2016 at 08:16:49 PM
Closed on 04/20/2017 at 06:02:22 PM
Last modified on 10/08/2019 at 05:46:27 PM
#3800 closed change (rejected)
Add tooltips to the options in the Tweaks section
Reported by: | sebastian | Assignee: | saroyanm |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | User-Interface | Keywords: | new-settings-page |
Cc: | greiner, athornburgh, lisabielik, saroyanm | Blocked By: | #2374 |
Blocking: | #2372 | Platform: | Unknown / Cross platform |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by saroyanm)
Background
Some of the options implemented with #2374 require further explanation. Other parts of the new options page already use tooltips to add explanations. So should we do here.
What to change
Add following tooltips to the corresponding option labels in the Tweaks section, using the same styles as for the tooltips shown for the "read more" links on the General tab:
- Show 'Block element' right-click menu item ->
This option allows you to generate and save filters for blocking certain elements on a page from the context menu.
Attachments (1)
Change History (13)
comment:1 Changed on 03/15/2016 at 03:59:42 PM by greiner
- Blocking 2372 added
comment:2 Changed on 03/15/2016 at 04:41:30 PM by sebastian
As discussed with Aaron via email (you have been CC) there will only be tooltips for those two options listed in the issue description.
comment:3 Changed on 03/15/2016 at 04:51:13 PM by greiner
- Ready set
Ok, I haven't looked at that email thread yet.
comment:4 Changed on 04/09/2016 at 01:46:29 PM by sebastian
- Description modified (diff)
I added a sentence to the tooltip for Safari's native content blocking, as it turned out that disabling it requires a browser restart. Let me know if anybody has a better idea how to phrase it.
comment:5 Changed on 06/08/2016 at 04:32:59 PM by greiner
- Owner set to greiner
Changed on 06/08/2016 at 05:06:44 PM by greiner
Comparing current implementation (above) with existing design (below)
comment:6 Changed on 06/08/2016 at 05:08:38 PM by greiner
Just a quick update on this:
1) Based on existing designs, the style won't be the same as for the "read more" links (apart from the underline).
2) There are two further items in the Tweaks section for which there's no tooltip yet:
- Show 'Adblock Plus' panel in the developer tools
- Show useful notifications
Please let me know whether you want to have tooltips for those as well, and if so: which ones.
3) Seeing it side-by-side with the existing design shows how helpful it might be to have a highlighted section for each of the options.
You can see all of the options from the screenshot by following this link and navigating to the Advanced tab.
comment:7 Changed on 01/24/2017 at 11:58:26 AM by saroyanm
- Cc saroyanm added
- Description modified (diff)
- Keywords new-settings-page added
Safari implementation are irrelevant after the drop of the safari for the new settings page launch.
comment:8 Changed on 01/24/2017 at 12:35:31 PM by saroyanm
@greiner I noticed that the ticket is assigned to you. Can you please remove assignment if you are not working/planing to work in near future.
comment:9 Changed on 01/24/2017 at 03:53:30 PM by saroyanm
- Owner changed from greiner to saroyanm
comment:10 Changed on 01/27/2017 at 03:26:25 PM by saroyanm
@Lisa:can you please confirm that the text in the description is fine with you, also can you please provide tooltip description for the Tweak section items below:
- Show 'Adblock Plus' panel in the developer tools
Please let me know if you need more details about the setting items.
Note: No need to provide text for Notifications checkbox yet, still need to align with Jeen, while in new design visuals drafts the toolip for the item is missing and text differs from current one.
comment:11 Changed on 04/20/2017 at 06:02:22 PM by saroyanm
- Resolution set to rejected
- Status changed from new to closed
The text here is outdated and should be taken care according to the specification and separately as part of #5158.
comment:12 Changed on 05/29/2019 at 10:52:28 AM by NathanGamer
spam
We still need to define texts for the "Show 'Adblock Plus' panel in the developer tools" option (see #2374).