Opened on 03/16/2016 at 01:55:55 PM

Closed on 03/16/2016 at 02:54:32 PM

#3814 closed defect (fixed)

Opening sharing pop-up fails starting with Firefox 47

Reported by: trev Assignee: trev
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29338436/

Description (last modified by trev)

How to reproduce

  1. Go to chrome://adblockplus/content/ui/firstRun.html
  2. Click Facebook icon

Observed behaviour

Sharing pop-up loads but doesn't become visible. Scripts from social widgets complain about not being able to access postMessage.

Expected behaviour

Sharing pop-up becomes visible.

Background

​https://bugzilla.mozilla.org/show_bug.cgi?id=1227861 removed nsIDocShell.setIsBrowserInsideApp() method. The replacement is currently nsIDocShell.frameType property but this will change again once ​https://bugzilla.mozilla.org/show_bug.cgi?id=1252794 is resolved.

Attachments (0)

Change History (4)

comment:1 Changed on 03/16/2016 at 02:06:18 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/16/2016 at 02:23:13 PM by trev

  • Description modified (diff)

comment:3 Changed on 03/16/2016 at 02:53:41 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/adblockplusui/rev/eaf7a04285fa

comment:4 Changed on 03/16/2016 at 02:54:32 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.