Opened on 04/25/2014 at 10:26:01 AM
Closed on 03/09/2016 at 10:09:59 AM
#382 closed change (fixed)
Remove support for "experimental" Chrome builds
Reported by: | trev | Assignee: | sebastian |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Automation | Keywords: | goodfirstbug |
Cc: | sebastian | Blocked By: | |
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
https://codereview.adblockplus.org/29337984 |
Description
Background
We currently have two flavors of Chrome development builds: a regular and an "experimental" one. We no longer link to the later but it is still being generated. Originally the experimental builds were used to test webRequest API before it became stable, now they no longer serve any purpose. With the development builds moving to CWS in #364 the experimental builds need to go - CWS won't allow us uploading them.
What to change
Remove the --experimental switch and all code connected to it from build tools. Also remove the experimental config setting and all code connected to it from sitescripts.extensions. Finally, make https://downloads.adblockplus.org/devbuilds/adblockpluschrome-experimental/ and https://downloads.adblockplus.org/devbuilds/adblockpluschrome/ show the same content and stop generation of experimental builds.
Attachments (0)
Change History (7)
comment:1 Changed on 08/14/2014 at 06:43:43 PM by trev
- Platform set to Unknown
- Priority changed from P2 to P3
comment:2 Changed on 01/21/2016 at 12:52:21 PM by sebastian
- Keywords goodfirstbug added
- Tester set to Unknown
comment:3 Changed on 03/08/2016 at 05:34:05 PM by sebastian
- Owner set to sebastian
comment:4 Changed on 03/08/2016 at 05:38:37 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 03/09/2016 at 10:03:51 AM by abpbot
comment:6 Changed on 03/09/2016 at 10:06:57 AM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/sitescripts/rev/2f150f9b99c4
comment:7 Changed on 03/09/2016 at 10:09:59 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
https://hg.adblockplus.org/buildtools/rev/becc043671e9