Opened on 03/17/2016 at 09:36:18 PM
Closed on 03/18/2016 at 06:03:45 PM
Last modified on 05/25/2016 at 02:10:43 PM
#3829 closed change (fixed)
Merge add-subscription and subscriptions.add messages
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29338595 |
||
Description
Background
Currently, there are two very similar message types add-subscription and subscriptions.add. The former is the only one in the adblockplusui repository that still uses the old naming scheme, and the only difference is that it brings up the options page asking the user to confirm adding the given subscription, while the later silently adds the given subscription.
What to change
Merge add-subscription message type into subscriptions.add and adapt the calling code.
Attachments (0)
Change History (7)
comment:1 Changed on 03/17/2016 at 09:44:26 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/18/2016 at 10:47:08 AM by greiner
- Ready set
comment:3 Changed on 03/18/2016 at 10:47:26 AM by greiner
- Priority changed from Unknown to P3
comment:4 Changed on 03/18/2016 at 01:31:55 PM by abpbot
comment:5 Changed on 03/18/2016 at 06:03:20 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/db4dfc97859e
comment:6 Changed on 03/18/2016 at 06:03:45 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 05/25/2016 at 02:10:43 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Adding subscriptions still works as expected after changes (except for subscribe link issue in older Chrome versions).
ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/536c9b810423