Opened on 04/25/2014 at 11:57:26 AM

Closed on 01/07/2016 at 09:10:38 PM

#384 closed defect (worksforme)

Wrong image shows up briefly for Adblock Plus icon

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc:, arthur, trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):


This isn't an issue I can reproduce but it is fairly obvious what is causing it. Here the original report from the blog:

The only problem I have is a “blinking” of the UI when Firefox starts : It seems like a line of icons appears and disappears at the top of the browser. Nothing really serious but it’s a bit annoying, and is clearly related to adblock+ as everything works fine when it’s disabled.


Adblock Plus icon uses toolbar-1 class to ensure correct styling. Among the default styles for this class is the following:

list-style-image: url("chrome://browser/skin/Toolbar.png");

We override it in our own styles but it seems that under some conditions these style load after the button is inserted in the document - meaning that for a brief time chrome://browser/skin/Toolbar.png is displayed as the image here.

What to change

We can add style="list-style-image: none;" attribute to the icon, this will make sure that the default style cannot apply. Our styles can then override that attribute using !important flag.

Attachments (0)

Change History (14)

comment:1 Changed on 04/27/2014 at 11:26:39 AM by mapx

  • Cc added

comment:2 Changed on 04/28/2014 at 02:48:57 PM by arthur

  • Cc arthur added

I can reproduce this. Let me know if you need anything.

comment:3 Changed on 04/28/2014 at 06:38:58 PM by trev

Only confirming once this is fixed - I'm fairly certain that the solution I outlined will do.

comment:4 Changed on 05/09/2014 at 06:48:16 AM by trev

  • Owner set to trev

comment:5 Changed on 05/09/2014 at 06:48:28 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 05/09/2014 at 11:19:49 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Should be fixed:

Arthur, there will be a new development build in five minutes, could you verify that this issue is really fixed?

comment:7 Changed on 05/09/2014 at 11:20:32 AM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:8 Changed on 05/09/2014 at 12:45:03 PM by arthur

  • Resolution fixed deleted
  • Status changed from closed to reopened

It is still happening for me with

Apparently this bug doesn't seem to affect Firefox 29 with the new Australis design but the old one below 29.

comment:9 Changed on 05/09/2014 at 01:26:47 PM by trev

  • Cc trev added
  • Owner trev deleted

Backed out the change:

Unfortunately, I still cannot reproduce this, not even with Firefox 28.

comment:10 Changed on 05/23/2014 at 07:18:40 AM by trev

  • Keywords goodfirstbug removed
  • Milestone Adblock-Plus-2.6.1-for-Firefox deleted

I was able to reproduce this on Windows with Firefox 28 by slowing down startup (added several filter subscriptions and made sure two fairly heavy tabs load on startup). The fix above indeed doesn't work for some reason, the style attribute is simply ignored. If I change attributes of the element then all the sudden the styles apply.

comment:11 Changed on 05/23/2014 at 11:04:40 AM by trev

  • Owner set to trev

comment:12 Changed on 05/23/2014 at 11:07:59 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

In the end the only solution appears to be removing the toolbarbutton-1 class in Firefox. Not having it in Thunderbird apparently makes our icon look better as well. SeaMonkey is the only place where we actually need it, so I made sure it is added there (had to restore handling of defaultToolbarPosition.addClass which apparently got lost in the Australis update).

comment:13 Changed on 07/09/2014 at 12:38:11 PM by philll

  • Platform set to Firefox

comment:14 Changed on 01/07/2016 at 09:10:38 PM by trev

  • Resolution set to worksforme
  • Status changed from reviewing to closed
  • Tester set to Unknown

I'm closing these since we no longer support pre-Australis versions of Firefox.

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Note: See TracTickets for help on using tickets.