Opened on 03/19/2016 at 02:49:05 PM
Closed on 03/19/2016 at 03:23:24 PM
Last modified on 05/26/2016 at 10:20:52 AM
#3840 closed change (fixed)
Prevent websites from making collapsed elements visible again
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
When Adblock Plus blocks an element, like an image or frame, it also hides the blocked element in order to prevent placeholders to show up and make more space for the actual content.
However, websites can override the style applied by Adblock Plus, in order to hide those elements. Some websites, e.g. pornhub.com (NSFW), do so in an attempt to circumvent ad blocking.
While making those elements visible again, only brings back the placeholders, this is still annoying. And in combination with other circumvention techniques it might even cause some ads to show up.
What to change
Use a MutationObserver to detect and prevent collapsed elements from being made visible again.
Attachments (0)
Change History (4)
comment:1 Changed on 03/19/2016 at 02:50:45 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/19/2016 at 03:21:53 PM by abpbot
comment:3 Changed on 03/19/2016 at 03:23:24 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/26/2016 at 10:20:52 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04
Safari 6 / OS X 10.8
Safari 9.1 / OS X 10.11
Opera 36 / Ubuntu 14.04
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/86c602085b39