Opened on 03/19/2016 at 08:31:55 PM
Closed on 03/23/2016 at 01:36:42 PM
Last modified on 05/26/2016 at 10:28:45 AM
#3842 closed change (fixed)
Split up the logic updating the icon and context menu
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
There is code in background.js to update the icon and context menu. This code however rather belongs into the icon and filterComposer modules.
What to change
- Move the logic detecting whether a page's whitelisting status changed into the whitelisting module.
- Split up the logic updating the icon and context menu, and move it into the icon and filterComposer modules.
Attachments (0)
Change History (4)
comment:1 Changed on 03/19/2016 at 08:34:12 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/23/2016 at 01:33:17 PM by abpbot
comment:3 Changed on 03/23/2016 at 01:36:42 PM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/26/2016 at 10:28:45 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Change does not look to have caused any regressions with icon and context menu. Whitelisting works as expected and the icon/context menu pick up on the change.
ABP 1.11.0.1606
Chrome 31, 45, 50 / Windows 7
Chrome 32, 49 / OS X 10.11
Chrome 49 / Ubuntu 14.04
Safari 6 / OS X 10.8
Safari 9.1 / OS X 10.11
Opera 36 / Ubuntu 14.04
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/f9af47ee1d80