#3956 closed defect (fixed)

abp2blocklist doesn't generate rules from domain whitelisting filters

Reported by:	kzar	Assignee:	kzar
Priority:	P2	Milestone:
Module:	Platform	Keywords:	abp2blocklist
Cc:	sebastian	Blocked By:
Blocking:	#3687	Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29340694/

NodeJS 5.10.0
abp2blocklist 349d23311c0c

echo '@@||example.com^$document' | node abp2blocklist.js

Result is an empty array []

Result should be

[{trigger: {"url-filter": ".*",
            "if-domain": ["example.com", "www.example.com"]},
  action: {type: "ignore-previous-rules"}}]

This is blocking the adding support for content blockers to Safari as it is breaking website whitelisting.
Wildcards and paths are not supported for if-domain, so we will have to ignore $document whitelisting rules that use either of those.

Summary:
Description:	You may use WikiFormatting here. === Environment === NodeJS 5.10.0 abp2blocklist 349d23311c0c === How to reproduce === `echo '@@\|\|example.com^$document' \| node abp2blocklist.js` === Observed behaviour === Result is an empty array `[]` === Expected behaviour === Result should be {{{ [{trigger: {"url-filter": ".*", "if-domain": ["example.com", "www.example.com"]}, action: {type: "ignore-previous-rules"}}] }}} === Notes === - This is blocking the adding support for content blockers to Safari as it is breaking website whitelisting. - Wildcards and paths are not supported for `if-domain`, so we will have to ignore $document whitelisting rules that use either of those.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/29340694/