Opened on 04/27/2016 at 05:33:05 PM

Closed on 04/27/2016 at 06:19:24 PM

#3999 closed change (fixed)

Response to filters.get/cssproperties message should contain filter text

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #3969, #4000 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29340898/

Description

Background

For #3969 we need to count hits of matching CSS property filters. For that the content script needs to know the actual filter text, the current response data.

What to change

When responding to the filters.get message requesting CSS property filters, there should be a text field containing full filter text.

Attachments (0)

Change History (4)

comment:1 Changed on 04/27/2016 at 05:37:04 PM by trev

  • Blocking 4000 added

comment:2 Changed on 04/27/2016 at 05:44:14 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 04/27/2016 at 06:17:26 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/adblockplusui/rev/f0daa0b325ed

comment:4 Changed on 04/27/2016 at 06:19:24 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.