Opened on 04/27/2016 at 05:37:04 PM

Closed on 04/27/2016 at 06:19:37 PM

#4000 closed change (fixed)

cssProperties.js content script should report matching filters

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Core Keywords:
Cc: Blocked By: #3999
Blocking: #3969 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29340901/

Description

Background

For #3969 we need the cssProperties.js content script to report matching filters and not just the selectors that should be put in place.

What to change

Add a parameter to addSelectorsFunc, an array of filters (as text) corresponding with the selectors. The filter text should be available once #3999 is fixed.

Attachments (0)

Change History (3)

comment:1 Changed on 04/27/2016 at 05:45:38 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/27/2016 at 06:17:51 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/adblockpluscore/rev/f7f491edb1b7

comment:3 Changed on 04/27/2016 at 06:19:37 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.