Opened on 05/17/2016 at 02:59:47 PM
Closed on 05/24/2017 at 11:02:16 AM
#4046 closed change (worksforme)
Set up proguard
| Reported by: | rjeschke | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | diegocarloslima | Blocked By: | |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
adblockplussbrowser does currently not use proguard for minimizing APK size.
What to change
Enable and configure proguard.
Attachments (0)
Change History (3)
comment:1 Changed on 05/22/2017 at 02:30:32 PM by jwangenheim
- Owner set to jwangenheim
comment:2 Changed on 05/23/2017 at 01:55:22 PM by jwangenheim
- Cc diegocarloslima added
Last edited on 05/24/2017 at 09:08:29 AM
by jwangenheim
comment:3 Changed on 05/24/2017 at 11:02:16 AM by diegocarloslima
- Resolution set to worksforme
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
Since @diegocarloslima migrated the project to Gradle / Android Studio, we use the getDefaultProguardFile('proguard-android.txt') method, which gets the default ProGuard settings from the Android SDK tools/proguard/ folder.
As we currently don't use any libs (except android.support:support-v4), the default ProGuard rules are okay for this project. The APK gets shrinked from 1.6 to 1 MB.
So I think this issue can be marked as resolved.