Opened on 05/25/2016 at 05:50:34 PM

Closed on 05/25/2016 at 06:21:34 PM

#4071 closed change (rejected)

Speed up ElemHide.getSelectorsForDomain for domains with no filters

Reported by: kzar Assignee: kzar
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: trev, sebatsian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29344551/

Description

Background

In #235 and #4057 we have been working to improve the performance of ElemHide.getSelectorsForDomain. As Sebastian pointed out however we didn't consider the common case of domains with no matching filters too carefully. In real world usage these domains are very common, so improving the performance for that case would be useful.

What to change

Investigate ideas about how we can improve the performance of ElemHide.getSelectorsForDomain for domains with no matching filters.

Attachments (0)

Change History (2)

comment:1 Changed on 05/25/2016 at 05:53:00 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 05/25/2016 at 06:21:34 PM by kzar

  • Resolution set to rejected
  • Status changed from reviewing to closed

(We decided in IRC that this function doesn't need to be further sped up for now.)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.